Fix special var names#37
Open
Timendus wants to merge 5 commits into
Open
Conversation
…rse entry names and comments
Collaborator
|
The comment field isn't exposed by TI to the user AFAIK so I guess you can just use normal ASCII. But regardless, it's 42 free bytes, they could be anything! |
Owner
Author
|
This PR probably still has a bug. Programs with special characters in their name can't be deleted normally from the calculator. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #32
This should hopefully be a fix for the issues with sending variables with special characters in their names. Probably needs a bit more testing, but this at least fixes sending programs with a
θin their name for me.If anyone is in the mood to give this a test themselves, that would be much appreciated. Otherwise I'll test it some more and see if I run into any more issues myself.
A question that I had while doing this: what encoding does the "comment" field in a TI file use?
TODO