Zoom toolbar#537
Merged
Merged
Conversation
azfoo
force-pushed
the
feat/zoom-levels
branch
2 times, most recently
from
8348bdb to
08efde9
Compare
FelipeDefensor
approved these changes
Jun 22, 2026
FelipeDefensor
left a comment
FelipeDefensor
left a comment
Collaborator
There was a problem hiding this comment.
So cool! Thanks :). I debounced the text entry and made the magnifiers a bit smaller. If you are okay with that, feel free to merge.
vertical scrollbar was not appearing on file load
- Replaces ZOOM_FACTOR / on_zoom("in"/"out") with ZOOM_MULTIPLIER = 1.25;
view.zoom.set/in/out commands registered in TimelineUIs.
- New ZoomToolbar (bottom toolbar): [ZoomOut][log-slider][ZoomIn][%spinbox].
Toolbar is display-only; synced via Post.ZOOM_TOOLBAR_UPDATE.
- _apply_zoom rejects new_width < 1 or > MAX_PLAYBACK_WIDTH.
- Adds Get.CURRENT_ZOOM (owned by TimelineUIs) and Get.ZOOM_REFERENCE_WIDTH.
- settings.get_file_zoom / save_file_zoom store the ratio at
private/recent_files/{path}/zoom in QSettings.
- FileManager.save() fetches Get.CURRENT_ZOOM and passes it to
update_recent_files.
- TimelineUIs._on_file_loaded reads the stored ratio, sets self._zoom,
and posts ZOOM_TOOLBAR_UPDATE (display only; _on_duration_available
applies it once duration is known).
…t stale coordinate state
CURRENT_ZOOM, ZOOM_REFERENCE_WIDTH and ZOOM_TOOLBAR_UPDATE were wedged mid-list; move them to the end so the enums stay ordered.
- setKeyboardTracking(False): commit on Enter/focus-out, not per keystroke - 16px icons + matching 12px slider handle
Cover the log-scale slider round-trip, spin box commit, toolbar sync on ZOOM_TOOLBAR_UPDATE, and the reject-and-revert path.
Collaborator
Author
|
Looks sensible! 0.6.3 or 0.7.0? |
also uses slightly more contrasting colours, especially in light mode.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.