fix(load-dialog): keep recent-message list inside the modal - #129
Merged
Conversation
The recent-messages picker rows overflowed the dialog horizontally: with `min-width: auto` at every flex/grid level between each row's `shrink-0` timestamp and the dialog's fixed width, intrinsic content width won and long labels/timestamps spilled past the modal edge instead of truncating. Add `min-w-0` down the chain (content wrapper, recent section, scroll container, item button, title row) so widths resolve to the dialog and the existing `truncate` takes effect. Also bump the message-label to text-sm to match the channel name, and make the formatted date bold black while leaving the raw `(ts)` muted/monospace. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Contributor
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
block-kitchen | ba64391 | Commit Preview URL Branch Preview URL |
Jun 30 2026, 06:25 AM |
…cent rows Force the dialog subtitle row left-aligned (the shared DialogHeader centers it below the sm breakpoint). Remove the per-row channel name from the recent-message list since the user already picks the channel above it. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
The "Edit an existing message" dialog's recent-message picker rows overflowed the modal horizontally. With
min-width: autoat every flex/grid level between each row'sshrink-0timestamp and the dialog's fixed width, intrinsic content width won, so long labels and timestamps spilled past the modal edge instead of truncating.min-w-0down the chain (content wrapper → recent section → scroll container → each item button → the title row) so widths resolve to the dialog and the existingtruncatetakes effect.text-smso it matches the channel name.font-semibold text-foreground) while leaving the raw(ts)muted/monospace.Why
Long recent-message labels/timestamps broke the modal layout (see attached repro). The truncation classes were already present but never engaged because no ancestor allowed shrinking.
Reviewer notes
Verified in the demo: with a screenshot-length label the item's right edge sits at
582pxinside the607pxdialog (truncates); without the fix it extended to2081px. Pure CSS-class change, no logic touched.