Meson support for Xvnc for xserver master branch with a patch - #2064
Meson support for Xvnc for xserver master branch with a patch#2064kohnish wants to merge 1 commit into
Conversation
CendioOssman
left a comment
CendioOssman
left a comment
There was a problem hiding this comment.
Thanks for the refresh of this PR. But I'm still sceptical to merge this whilst there is no release of the master branch and everything is a moving target.
Is there any distribution that uses the master branch?
We can have this PR as a draft for reference until then, though.
| dependency('zlib'), | ||
| dependency('pam'), | ||
| dependency('gnutls'), | ||
| dependency('nettle'), | ||
| dependency('hogweed'), | ||
| dependency('gmp'), | ||
| dependency('libjpeg'), |
There was a problem hiding this comment.
As mentioned in the original PR, this is duplication we want to avoid. So we'd like some clever way of providing this information to Meson based on what's in our CMake files.
| 'vncDRI3.c', | ||
| 'vncDRI3Draw.c', |
There was a problem hiding this comment.
Aren't these conditional, like for autoconf?
| '../../../../common', | ||
| '../../../common', | ||
| '../../../vncconfig', |
There was a problem hiding this comment.
We should probably have a tigervnc_srcdir like we do for autoconf, to support different ways of building Xvnc.
| srcs_xvnc, | ||
| include_directories : [inc, xvnc_inc], | ||
| dependencies: common_dep, | ||
| c_args: ['-DTIGERVNC', '-DNO_MODULE_EXTS'], |
Thanks for the reviews. I made a commit as a gentoo user for the benefit for myself. I feel like xvnc user is only myself. Gentoo has this concept of live builds that just build master. It's quite useful to try the latest features/fixes of things, also beneficial on official version bump. Possibly Arch AUR supports something similar. I'm happy to address the review remarks if you think it makes sense to merge it at all. Otherwise, I think closing is also fine. |
|
Let's keep this PR in limbo as a draft until Xorg's main branch stabilises. They seem to be aiming for a release soon-ish, at which point we can merge it. So feel free to have a look at my feedback and keep the branch up to date until the time comes to merge things. |
2 participants
I've finished the work of #1729 and tested with the latest xserver master.
Their master branch is changeable, so the patch file is will be update on the best effort basis.