Repository navigation
Fix docs themes, code presentation, and evidence page - #288
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
tidelight/app/developers/packages/packages.css
Lines 216 to 217 in ad39e2f
Preserve the reduced-motion override for package cards
For users with prefers-reduced-motion: reduce, the earlier rule at line 189 disables card transitions, but this later and more-specific selector restores a transform transition and the hover rule animates a three-pixel translation. The cascade therefore defeats the repository's reduced-motion handling on every package directory card; move an equally specific reduced-motion override after these rules or omit the transform animation under that preference.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| <p>Review the public artifacts, account-scoped records, and reproducibility criteria associated with Tidelight’s S2 submission.</p> | ||
| <div className="evidence-note"><b>Scope</b><span>{manifest.evidence_boundary.note}</span></div> |
There was a problem hiding this comment.
This rewrite removes both limitation statements enforced by tests/evidence-manifest.test.mjs: that the index is “not a performance claim” and that the historical report must not be interpreted as positive-alpha evidence. The evidence test now fails at line 20 and would subsequently fail at line 21, blocking CI; retain those explicit disclosures while applying the new presentation.
Useful? React with 👍 / 👎.
| .evidence-page{--evidence-accent:var(--brand-teal,var(--mint-2));min-height:100vh;padding:24px clamp(20px,5vw,76px) 64px;background:radial-gradient(circle at 85% 0%,color-mix(in srgb,var(--evidence-accent) 13%,transparent) 0,transparent 33%),var(--bg);color:var(--text)} | ||
| .evidence-page a{color:var(--evidence-accent);text-decoration:none}.evidence-page a:hover{text-decoration:underline} |
There was a problem hiding this comment.
In Daylight mode, the globally defined --brand-teal (#29c8bb) is selected here, so the --mint-2 fallback is never used; against the Daylight page and panel backgrounds its contrast is only about 1.7–2.1:1. This makes every evidence link, kicker, and default status fail normal-text contrast, whereas the theme-specific Daylight accent is deliberately darker. Set this from the theme token or provide a Daylight override.
Useful? React with 👍 / 👎.
| <button type="button" className="tic-code-copy" onClick={copy} aria-live="polite" aria-label={status === "copied" ? "Code copied" : "Copy code"}> | ||
| {status === "copied" ? "Copied" : status === "failed" ? "Copy unavailable" : "Copy code"} |
There was a problem hiding this comment.
When navigator.clipboard.writeText rejects—for example because clipboard access is unavailable or denied—the visible text changes to “Copy unavailable,” but the button's aria-label remains “Copy code.” Because that label supplies the accessible name inside the live region, screen-reader users receive no failure state and may believe copying succeeded; include the failed state in the accessible label as well.
Useful? React with 👍 / 👎.
Summary
Verification