fix(Review): M0/M1/M2 审查修复(正确性 + 测试补齐) - #5
Merged
Conversation
…push 警告/linter 等); 🤖 Generated with [Claude Code](https://github.com/claude), [CodeX](https://openai.com), [Gemini](https://github.com/apps/gemini-code-assist) Co-Authored-By: Aurelius Huang<threefish.ai@gmail.com>
…git-status-map 全量/amend 集成; 🤖 Generated with [Claude Code](https://github.com/claude), [CodeX](https://openai.com), [Gemini](https://github.com/apps/gemini-code-assist) Co-Authored-By: Aurelius Huang<threefish.ai@gmail.com>
🤖 Generated with [Claude Code](https://github.com/claude), [CodeX](https://openai.com), [Gemini](https://github.com/apps/gemini-code-assist) Co-Authored-By: Aurelius Huang<threefish.ai@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
背景
对已合并的 M0/M1/M2 进行 3 路独立 code review(正确性 / 架构合规 / 完整性与测试),交叉复核后修复高置信度真实问题。
正确性修复
onDidChange订阅累积泄漏 → 单repoSub+ 切换/卸载 dispose。startsWith无路径边界误匹配 →api.getRepository(folder.uri)精确匹配。indexChanges(已暂存文件不可见)→ 合并 index/working/untracked 去重。restore --staged,勾选集成为提交权威范围(对齐 IDEA)。ok:true+warning。onDidChange入subscriptions(卸载泄漏)。await repo.status()后刷新(避免陈旧)。\r\n+ 中文/Unicode scope。onDidReceiveMessage绑onDidDispose;nonce 用crypto.randomBytes;选中态setState持久化。CommitFileItem冗余字段。测试补齐(+16 项)
ConventionalCommitCheck(enable/disable/阻断,5 项)。CommitService.executeCommit(mock Repository:CC 阻断/无文件/amend 透传/unstage/push 警告,7 项)。git-status-map全量覆盖(19 个 GitStatus,+1 项)。验收
文档化延后(非 bug)
commit()API 不支持--author(API 限制)。🤖 Generated with Claude Code