Skip to content

fix(Review): M0/M1/M2 审查修复(正确性 + 测试补齐) - #5

Merged
ThreeFish-AI merged 3 commits into
feature/1.x.xfrom
ThreeFish-AI/review-m0m1m2-fixes
Jun 27, 2026
Merged

fix(Review): M0/M1/M2 审查修复(正确性 + 测试补齐)#5
ThreeFish-AI merged 3 commits into
feature/1.x.xfrom
ThreeFish-AI/review-m0m1m2-fixes

Conversation

@ThreeFish-AI

Copy link
Copy Markdown
Owner

背景

对已合并的 M0/M1/M2 进行 3 路独立 code review(正确性 / 架构合规 / 完整性与测试),交叉复核后修复高置信度真实问题。

正确性修复

  • GitRepositoryService:仓库切换 onDidChange 订阅累积泄漏 → 单 repoSub + 切换/卸载 dispose。
  • pickRepositorystartsWith 无路径边界误匹配 → api.getRepository(folder.uri) 精确匹配。
  • getChanges:缺失 indexChanges(已暂存文件不可见)→ 合并 index/working/untracked 去重。
  • commit 语义:未勾选的已暂存文件先 restore --staged,勾选集成为提交权威范围(对齐 IDEA)。
  • push 失败:commit 已成功却报「提交失败」→ ok:true + warning
  • extension.ts:三个 onDidChangesubscriptions(卸载泄漏)。
  • refreshawait repo.status() 后刷新(避免陈旧)。
  • conventional-linter:Windows \r\n + 中文/Unicode scope。
  • commit-webviewonDidReceiveMessageonDidDispose;nonce 用 crypto.randomBytes;选中态 setState 持久化。
  • changes-tree:tooltip 显示状态全称;清理 CommitFileItem 冗余字段。

测试补齐(+16 项)

  • ConventionalCommitCheck(enable/disable/阻断,5 项)。
  • CommitService.executeCommit(mock Repository:CC 阻断/无文件/amend 透传/unstage/push 警告,7 项)。
  • git-status-map 全量覆盖(19 个 GitStatus,+1 项)。
  • amend 真实集成(改写 HEAD 不新增 commit)。

验收

结果
check-types / lint / package
test:unit 45/45
test:integration 3/3(含 amend)

文档化延后(非 bug)

  • Author 覆盖:vscode.git 稳定 commit() API 不支持 --author(API 限制)。
  • PNG icon / CI action SHA pin:发布准备阶段处理。

🤖 Generated with Claude Code

…push 警告/linter 等);

🤖 Generated with [Claude Code](https://github.com/claude), [CodeX](https://openai.com), [Gemini](https://github.com/apps/gemini-code-assist)
Co-Authored-By: Aurelius Huang<threefish.ai@gmail.com>
…git-status-map 全量/amend 集成;

🤖 Generated with [Claude Code](https://github.com/claude), [CodeX](https://openai.com), [Gemini](https://github.com/apps/gemini-code-assist)
Co-Authored-By: Aurelius Huang<threefish.ai@gmail.com>
🤖 Generated with [Claude Code](https://github.com/claude), [CodeX](https://openai.com), [Gemini](https://github.com/apps/gemini-code-assist)
Co-Authored-By: Aurelius Huang<threefish.ai@gmail.com>
@ThreeFish-AI
ThreeFish-AI merged commit 9cfc31f into feature/1.x.x Jun 27, 2026
4 checks passed
@ThreeFish-AI
ThreeFish-AI deleted the ThreeFish-AI/review-m0m1m2-fixes branch June 27, 2026 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant