Repository navigation
Add structured JSONHTML layouts and bounded native previews - #30
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JSONHTML now renders ordered objects as structured forms and complex arrays as indexed cards, with explicit syntax layout and independent static/interactive presentation. Bounded string prefixes, sRGB swatches, declared PNG/JPEG, a small native inline dialect and atomic MathML previews preserve full exact JSON/source/copy/download access. Complete exports, print and guarded PDF use immutable prepared renderer policy; the HTML-only CLI switches share that renderer.
The reviewed head
bc05d79preserves current main's six libraries plus swift-json, empty root dependencies and private runtimes. Final review corrected an integration regression by restoring the existing five-command export lane and event I/O/error/console diagnostics. Exact test discovery, named parameter inventories and all 49 cap meanings remain enforced. Library/CLI/tests/assets/fixtures are unchanged from the previously qualified 80b5ea7 implementation.All seven fresh hosted checks passed: Native behavior/safety/docs and Linux behavior/safety on x86_64 and arm64. Native debug/release and ASan ran 419 functions/325 parameter cases, with 15 shared TSan functions; Linux ran 403/325 and 14 TSan functions. Six DocC catalogues and 946 authored public declarations passed. Both Linux clean builds tested the same reproducible source archive. The restored local export lane passed 40 focused functions per configuration, 65 public consumer cases, eight artifacts, three Apple SDK declaration probes and two mobile SDK consumer builds. Two explicit fault-injection rejections verified missing/malformed-event diagnostics.
The 73-probe WASI result retains its actual 80b5ea7 source identity and is reused through exact implementation/fixture/WASI-harness equality, rather than claimed as a newly executed bc05d79 lane. The unchanged renderer retains its scoped browser/device/VoiceOver evidence and attributed manual observations. Logical retention, RSS, caller work and owned quotas remain distinct; the reviewed approximately 11% streaming disposition and unchanged 10% trigger remain in force. These consumer results do not establish MCP server/conformance gates.
Review is complete, with no remaining blocking finding or unresolved thread. The maintainer authorized readiness and merge after checks/reviews pass. Release placement, tagging and GitHub release publication remain separate.