Repository navigation
Qualify 1.2.1 test coverage and schema failure handling - #28
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This proposes the 1.2.1 qualification patch against
release/1.2, rooted at published 1.2.0 (25fb04f). Main advanced to JSONHTML/1.3 in PR #21; the maintainer explicitly approved this maintenance destination so that later features and sibling work remain untouched. Best-effort schema diagnostics now preserve ordinary invalidity when optional output exceeds its byte cap; required work/annotation failures remain terminal. A completely missing native schema bundle now throws structured metaSchema failure instead of trapping, with all nine integrity pins retained.Add 126 meaningful Swift Testing functions (318 roots / 173 parameterized invocations), including foreign/native Codable, exact values and failures, causal streaming/backpressure, schema/regex/Patch decisions and 20 public end-to-end functions. Coverage exports preserve five module denominators and exact six-target discovery, reject missing objects/saturated counters, and run on both Linux architectures. Fixed-seed replays and a 26-mutant native pilot supplement behavior assertions. No public API/product, dependency, profile, platform or 1.3.0 change.
Validation already materialized against matching implementation/test inputs:
Performance remains explicitly qualified by host conditions. The maintainer requested a matched run despite competing CPU load: ten processes / five alternating pairs measured 0.5761326 ms parent vs 0.5664125 ms current (−1.6871%); no sample discarded and work/logical-retention counters matched. Fifty observations recorded 2.61–58.56% idle CPU and load1 21.98–31.69 on ten cores. This does not resolve the earlier +11.9833% comparison or establish an intrinsic improvement. The unchanged 10% review trigger and outstanding quiet-host qualification remain visible; historical streaming disposition is unchanged.
See review readiness and receipts and acceptance outcomes. The maintainer authorized merging after source review and all Native/Linux checks pass. Quiet-host performance qualification remains a separate release follow-up; the loaded-host observation is not relabeled as controlled evidence. Existing physical-iPad deferral and WASI limitations remain. Merging, tagging and publication are separate actions.