Skip to content

rename cause to reason to avoid esnext conflicts#87

Open
saintedlama wants to merge 1 commit into
ThomWright:masterfrom
saintedlama:rename-cause-to-reason
Open

rename cause to reason to avoid esnext conflicts#87
saintedlama wants to merge 1 commit into
ThomWright:masterfrom
saintedlama:rename-cause-to-reason

Conversation

@saintedlama

Copy link
Copy Markdown

No description provided.

@ThomWright

Copy link
Copy Markdown
Owner

Hey, thanks for the PR.

Could you look at #85 and tell me if you think this would be better written as cause: Error instead of reason: string?

Thanks

@saintedlama

Copy link
Copy Markdown
Author

Will do a second PR and see what's happening using an Error as cause

@saintedlama

Copy link
Copy Markdown
Author

Hey, thanks for the PR.

Could you look at #85 and tell me if you think this would be better written as cause: Error instead of reason: string?

Thanks

Works with using type Error for cause. New PR #88

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants