fix(import): support multi-file markdown drops#210
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
b9ce02d to
c64a118
Compare
Deploying markdownviewer with
|
| Latest commit: |
c64a118
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://74720609.markdownviewer.pages.dev |
| Branch Preview URL: | https://codex-fix-multi-file-drop-im.markdownviewer.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes multi-file local Markdown imports so drag-and-drop processes every supported dropped file instead of only
files[0].What changed
importMarkdownFilepromise-based so dropped files are opened sequentially in the browser-provided order.multipleon the hidden file input.Root cause
The drop handler read only the first item from
DataTransfer.files, so any additional valid Markdown files in the same drop were ignored. Reading files asynchronously without coordination could also risk tab ordering, so the new helper awaits each import in order.Validation
node --check script.jsnode --check desktop-app/resources/js/script.js01-first,02-second,03-third.http://127.0.0.1:4173/index.htmland confirmed the file input hasmultipleenabled.git diff --check(clean; Git reported only existing Windows line-ending conversion warnings).