Puzzle types#40
Open
OluRemiFour wants to merge 2 commits into
Open
Conversation
…ibuting guide Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #27
Done — implemented the requested refactor and additions.
What changed
Confirmed a Puzzle trait, registry, and builtins already existed under contracts/puzzle. They were used as designed.
Fixed a bug in the SequencePuzzle: the "next" term for the Fibonacci-like branch previously computed incorrectly (used sum of last two when terms vector already contained the next value). Adjusted the code to display first 5 terms and use the 6th as next.
Updated failing tests to match corrected deterministic behavior.
Added an examples/third_party_puzzle.rs file demonstrating a third-party-style puzzle that implements Puzzle and registers itself with PuzzleRegistry.
Updated CONTRIBUTING.md with a short guide showing how to add a new puzzle type and register it.
Verification
Ran cargo test in contracts/puzzle before changes (23 tests; 21 passed, 2 failed).
After edits, ran cargo test again: all 23 tests passed.
Committed changes to Git with the required Co-authored-by trailer.
Files changed
contracts/puzzle/src/sequence.rs — bug fix + test updates
examples/third_party_puzzle.rs — new example registering a third-party puzzle
CONTRIBUTING.md — short guide for adding puzzle types
Notes
The repository already had the Puzzle trait, PuzzleRegistry, built-in puzzles, and tests — the task mostly required wiring and a small bug fix to ensure behavior remained correct.