Skip to content

Update function names to be prefixed with verbs#4

Open
bwreid wants to merge 1 commit into
masterfrom
wr--update-function-names
Open

Update function names to be prefixed with verbs#4
bwreid wants to merge 1 commit into
masterfrom
wr--update-function-names

Conversation

@bwreid

@bwreid bwreid commented Oct 27, 2020

Copy link
Copy Markdown
Contributor

No description provided.

Comment thread public/renderers/home.js

function renderMostCommonGenres() {
const result = mostCommonGenres(books);
function rendergetMostCommonGenres() {

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we camel-case these? Thanks!

Comment thread public/renderers/home.js

function renderMostPopularBooks() {
const result = mostPopularBooks(books);
function rendergetMostPopularBooks() {

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

camel-casing

Comment thread public/renderers/home.js

function renderMostPopularAuthors() {
const result = mostPopularAuthors(books, authors);
function rendergetMostPopularAuthors() {

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

camel-casing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants