fix(cua): update driver and skill name#1902
Merged
Merged
Conversation
Contributor
📝 WalkthroughWalkthroughThis PR updates the bundled CUA driver reference from v0.6.7 to v0.7.1 across docs, plugin manifest, vendor metadata, and tool policies (adding ChangesCUA driver 0.7.1 update
Estimated code review effort: 3 (Moderate) | ~25 minutes Computer-use skill rename and active-skill migration
Estimated code review effort: 3 (Moderate) | ~20 minutes Sequence Diagram(s)sequenceDiagram
participant Session
participant skillPresenter
participant Storage
Session->>skillPresenter: getActiveSkills(sessionId)
skillPresenter->>skillPresenter: validateSkillNames resolves cua-driver via SKILL_NAME_ALIASES
skillPresenter->>skillPresenter: areSkillListsEqual compares resolved vs persisted list
skillPresenter->>Storage: persist normalized ['computer-use']
skillPresenter-->>Session: return ['computer-use']
Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
🧹 Nitpick comments (1)
test/main/presenter/pluginPresenter.test.ts (1)
1145-1158: 🎯 Functional Correctness | 🔵 Trivial | ⚡ Quick winAdd Darwin asset assertions.
plugins/cua/vendor/cua-driver/upstream.jsonalso listsdarwin-arm64anddarwin-x64assets, but this test only checks Windows and Linux filenames. Adding those two assertions would cover the fullsupportedTargetsset.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@test/main/presenter/pluginPresenter.test.ts` around lines 1145 - 1158, The CUA tool policy test in pluginPresenter.test should cover the full supportedTargets set, not just Windows and Linux filenames. Update the existing assertion block in the test around the CUA manifest/policy checks to also verify the Darwin assets from upstream.json by asserting the presence of both darwin-arm64 and darwin-x64 filenames alongside the current platform checks.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@test/main/presenter/pluginPresenter.test.ts`:
- Around line 1145-1158: The CUA tool policy test in pluginPresenter.test should
cover the full supportedTargets set, not just Windows and Linux filenames.
Update the existing assertion block in the test around the CUA manifest/policy
checks to also verify the Darwin assets from upstream.json by asserting the
presence of both darwin-arm64 and darwin-x64 filenames alongside the current
platform checks.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: ff69809e-3151-43ce-aa60-5b93bff742c2
📒 Files selected for processing (16)
docs/features/cua-cross-platform-computer-use/plan.mddocs/features/cua-cross-platform-computer-use/spec.mddocs/features/cua-cross-platform-computer-use/tasks.mddocs/issues/cua-computer-use-skill-name/spec.mddocs/issues/cua-driver-0-7-1-update/spec.mdplugins/cua/plugin.jsonplugins/cua/policies/tool-policy.jsonplugins/cua/skills/computer-use/README.mdplugins/cua/skills/computer-use/RECORDING.mdplugins/cua/skills/computer-use/SKILL.mdplugins/cua/skills/computer-use/TESTS.mdplugins/cua/skills/computer-use/WEB_APPS.mdplugins/cua/vendor/cua-driver/upstream.jsonsrc/main/presenter/skillPresenter/index.tstest/main/presenter/pluginPresenter.test.tstest/main/presenter/skillPresenter/skillPresenter.test.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cua-driver-rs-v0.7.1cua-drivertocomputer-usecua-drivertocomputer-useValidation
corepack pnpm exec vitest run test/main/presenter/pluginPresenter.test.tscorepack pnpm exec vitest run test/main/presenter/skillPresenter/skillPresenter.test.tscorepack pnpm run plugin:cua:build:mac:arm64corepack pnpm run plugin:cua:build:win:x64corepack pnpm run plugin:cua:build:linux:x64corepack pnpm run plugin:bundle -- --name cua --platform darwin --arch arm64corepack pnpm run formatcorepack pnpm run i18ncorepack pnpm run lintgit diff --checkCloses #1898
Closes #1900
Summary by CodeRabbit
New Features
Bug Fixes
Documentation