Skip to content

fix(app): require confirmation for memory deletion #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
comppaz merged 1 commit into from
Dec 23, 2025
Merged

fix(app): require confirmation for memory deletion #88

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .changeset/memory-delete-confirmation.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
---
"think-app": patch
---

fix: require confirmation for memory deletion

Remove delete button from memory card hover menu. Users must now open the
detail sidebar panel to delete a memory, which has a confirmation dialog.
12 changes: 0 additions & 12 deletions app/src/components/MemoryCard.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ import { Button } from "@/components/ui/button";
import {
Globe,
FileText,
Trash2,
X,
Link as LinkIcon,
PanelRight,
Expand All @@ -27,7 +26,6 @@ interface Memory {

interface MemoryCardProps {
memory: Memory;
onDelete: (id: number) => void;
onRemoveTag: (memoryId: number, tagId: number) => void;
onExpand: (id: number) => void;
formatDate: (date: string) => string;
Expand Down Expand Up @@ -65,7 +63,6 @@ function DomainBadge({ url }: { url: string }) {

export function MemoryCard({
memory,
onDelete,
onRemoveTag,
onExpand,
formatDate,
Expand Down Expand Up @@ -101,15 +98,6 @@ export function MemoryCard({
>
<PanelRight className="h-3.5 w-3.5" />
</Button>
<Button
variant="ghost"
size="icon"
onClick={() => onDelete(memory.id)}
className="h-7 w-7 text-muted-foreground hover:text-destructive"
title="Delete"
>
<Trash2 className="h-3.5 w-3.5" />
</Button>
</div>

{/* Header: Type icon + Title */}
Expand Down
1 change: 0 additions & 1 deletion app/src/pages/MemoriesPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -530,7 +530,6 @@ export default function MemoriesPage() {
<div key={memory.id} className="break-inside-avoid mb-4">
<MemoryCard
memory={memory}
onDelete={handleDelete}
onRemoveTag={handleRemoveTag}
onExpand={handleExpand}
formatDate={formatDate}
Expand Down