feat(app): replace add memory dialog with full-screen TipTap editor - #56
Merged
Conversation
- Add new TipTap-based NoteEditor component with formatting toolbar - Add EditorContent, EditorToolbar, EditorActionBar components - Add useSave hook for save state management - Remove AddMemoryDialog in favor of full-screen editing - Update MemoryDetailPanel to open editor for notes - Add TipTap prose styling and editor design tokens - Add FTS5 graceful fallback migration Closes #55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace the modal-based
AddMemoryDialogwith a full-screen TipTap-powered note editor for a better writing experience.Changes
New Components (
src/components/editor/)NoteEditor.tsx- Main full-screen editor componentEditorContent.tsx- TipTap wrapper with content syncEditorToolbar.tsx- Formatting toolbar (bold, italic, headings, lists, blockquote, code)EditorActionBar.tsx- Bottom action bar with save/discard and word countuseSave.ts- Save state management hookRemoved
AddMemoryDialog.tsx- Replaced by NoteEditorModified
MemoryDetailPanel.tsx- AddonOpenEditorprop for notesMemoriesPage.tsx- Use NoteEditor instead of dialogHomePage.tsx- "Add Memory" → "Add Note"index.css- TipTap prose stylingdesign-tokens.ts- Editor design tokensBackend
migrations.py- Migration 015: Handle FTS5 unavailability gracefullyDependencies Added
@tiptap/extension-placeholder@tiptap/pm@tiptap/react@tiptap/starter-kitCloses #55