feat: add Windows support - #45
Merged
Merged
Conversation
added 7 commits
December 17, 2025 12:26
- Add Windows icon (icon.ico) for NSIS installer - Configure electron-builder with NSIS settings - Update PyInstaller spec for cross-platform sqlite-vec detection - Create stub_win.spec for Windows native messaging stub - Add cross-platform build scripts (build-backend.js, build-stub.js) - Add Windows build job to GitHub Actions release workflow - Mark alpha/beta releases as prerelease automatically
The snok/install-poetry action doesn't add Poetry to PATH correctly on Windows. Using pip install instead.
The sqlite-vec Windows release is distributed as .tar.gz, not .zip.
On Windows, read_text()/write_text() can add UTF-8 BOM which causes the derived encryption key to differ between setup and unlock. Using binary mode (read_bytes/write_bytes) avoids encoding issues entirely since the salt is just ASCII hex characters.
rotki-pysqlcipher3 on Windows doesn't include FTS5 support. Migration 8 now checks if FTS5 is available before creating the virtual table. Search falls back to vector-only when FTS5 is unavailable. Also improved decrypt_db.py with cross-platform support and better CLI arguments.
- Replace blocking curl download with async https download - Show real download progress (5-80%) instead of hanging at 10% - Replace winreg dependency with built-in reg.exe commands - Remove unused winreg dependency from package.json
comppaz
marked this pull request as ready for review
December 17, 2025 16:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds full Windows support for the Think desktop app, including:
build-windowsjob in release workflow that builds NSIS installerwinregnpm dependency with nativereg.execommandscurl(not available on Windows) with nativehttpsmodule with progress reportingIssue
Closes #43
Changes
.github/workflows/release.yml.exeartifactapp/build/icon.icoapp/electron/install-native-host.jsreg.exeinstead ofwinregmoduleapp/electron/main.jshttpsdownload with progress, redirect handlingapp/package.jsonpng-to-ico, removedwinregbackend/app/db/migrations.pybackend/app/services/secrets.pybackend/native_host/stub_win.specbackend/scripts/decrypt_db.pybackend/think.specscripts/build-backend.jsscripts/build-stub.jsTest Plan