Skip to content

feat(app): improve UI styling and accessibility - #37

Closed
zachmcnair wants to merge 5 commits into
ThinkFoundation:mainfrom
zachmcnair:feat/app-ui-improvements
Closed

feat(app): improve UI styling and accessibility#37
zachmcnair wants to merge 5 commits into
ThinkFoundation:mainfrom
zachmcnair:feat/app-ui-improvements

Conversation

@zachmcnair

Copy link
Copy Markdown
  • Replace Work Sans font with Inter for better readability
  • Update dark mode color scheme for better contrast
  • Improve dropdown styling with proper background colors
  • Add max-width constraint (640px) to chat messages
  • Update selected chat item styling in light mode
  • Reduce sidebar navigation text size by 2pt
  • Fix orphaned words in setup completion modal
  • Update logo to use dark mode variant when appropriate

zachmcnair and others added 3 commits December 16, 2025 15:04
- Replace Work Sans font with Inter for better readability
- Update dark mode color scheme for better contrast
- Improve dropdown styling with proper background colors
- Add max-width constraint (640px) to chat messages
- Update selected chat item styling in light mode
- Reduce sidebar navigation text size by 2pt
- Fix orphaned words in setup completion modal
- Update logo to use dark mode variant when appropriate

@comppaz comppaz left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

Good improvements overall, but please address these consistency issues before merge:

  1. Hardcoded colors - Use design tokens instead of hex values
  2. Extension dark mode not synced - Colors don't match the app
  3. Title bar feature - Consider separating into its own PR

See line comments below for specifics.

@comppaz

comppaz commented Dec 17, 2025

Copy link
Copy Markdown
Collaborator

Line-specific feedback:


app/src/components/ChatSidebar.tsx:57
Use dark:bg-secondary instead of hardcoded #242633. The design tokens already define this color.


app/src/components/ChatSidebar.tsx:64
The dark:text-foreground override is unnecessary. Just use text-primary.


app/src/index.css:113-118
Use CSS variables in the dark mode gradient:

linear-gradient(to bottom right, hsl(var(--background)) 0%, hsl(var(--card)) 100%)

Instead of hardcoded hex values.


extension/src/content.css:38-58 ⚠️
Extension dark mode colors were not updated to match the app. The app now uses blue-tinted grays (232 53% 8%, 232 17% 17%) but extension still has pure grays (0 0% 3.9%, 0 0% 14.9%).


app/src/pages/ChatPage.tsx:281-319
The title bar feature is great, but consider separating it into its own PR. Keeps styling changes focused and easier to review.

…d UI improvements

- Replace hardcoded colors with design tokens across app and extension
- Sync extension dark mode colors with app (blue-tinted grays)
- Update extension popup and sidebar styling to match app design
- Fix background gradients to use CSS variables consistently
- Add logout button to settings page (floats right of title)
- Fix animated background orb colors to use correct blue hue
- Add protocol handler (think://) for opening app from extension
- Update extension icons for light/dark modes
- Improve font loading in extension popup
- Fix button width consistency in extension popup
@zachmcnair

Copy link
Copy Markdown
Author

@comppaz Thanks for the feedback! I've done a more thorough update across extension and app following your feedback. Mind reviewing?

@comppaz

comppaz commented Dec 17, 2025

Copy link
Copy Markdown
Collaborator

@zachmcnair I will review it by tmr 👍 If it looks fine in general and you don't mind, I would take it over and split it up in a few small PRs!

@comppaz

comppaz commented Dec 18, 2025

Copy link
Copy Markdown
Collaborator

@zachmcnair So in general what the PR aims to achieve looks good to me. But it should be actually at least 3 PRs not one, and not so many hardcoded / inline styles.

If you like I can take that over, split it and clean it up.

@zachmcnair

Copy link
Copy Markdown
Author

@comppaz Thanks for your grace. I'll make sure to make smaller PRs in the future. As for this PR, I'll work to split it up. I don't want to burden you. If I do a shit job in breaking it apart, I'll gladly accept your help! :)

@zachmcnair

Copy link
Copy Markdown
Author

@comppaz I used Opus 4.5 to help me split them off. Gonna leave this open just in case the others failed.

#51

#52

#53

#54

@comppaz

comppaz commented Dec 19, 2025

Copy link
Copy Markdown
Collaborator

I will close this in favor of:

#69 #67 #65 #63

The design changes are not included as on closer inspection they are not complete (and would require a new PR anyways).

@comppaz comppaz closed this Dec 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants