NCE-15 NCE-18 NCE-23 NCE-26: integrate remaining v3.1.0 QA fixes - #181
Merged
FortPT merged 6 commits intoAug 12, 2026
Merged
Conversation
Drive the server audit page size from the #audit-page-size selector via a
path-encoded /page/<n>/size/<s> route, clamp to {25,50,100,150,250,500},
and persist the choice in localStorage so it survives refresh and
section navigation.
On remove, clear the file input, hide the editor, reset zoom, close and null the decoded bitmap, and hide/disable the Save picture button — matching saveAvatar — so a chosen-but-unsaved image no longer lingers.
Collaborator
Author
|
Development UI validation update:
Expected next patch: leaving Settings without saving restores persisted values; successful save updates Jira NCE-15 has been updated with the same Development findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Integrate the remaining v3.1.0 QA fixes onto
release/v3.1.0-amber-webuiwithout reverting the Amber WebUI.NCE-15
en-US/pt-BRvalues valid for existing saved settings.NCE-18
Save picturevisibility/disabled state.NCE-23
NCE-26
Save picture.Validation on VM-09
node --check src/webui/i18n.js: passednode --check src/webui/app.js: passednode --check src/webui/qa_patch.js: passedpython -m compileall -q src: passed in earlier combined-branch validationpytest -q tests/test_webui.py: 11 passedtests/test_brand_identity.py: 1032 passedgit diff --check: cleantests/test_brand_identity.pyis omitted only on the non-elevated VM checkout because it recursively reads/docker/nowlert-ce/config/config.yaml, which is not readable by the normal VM user. CI should run it in a clean checkout.Development gate
Keep this PR in draft until the updated branch image has been deployed to CE Development and NCE-15 / NCE-18 / NCE-23 / NCE-26 have been checked in the running v3.1.0 UI. NCE-18 Save picture already passed Development validation; NCE-15 requires a fresh Development retest for translation and save/discard semantics.
Release path
This PR targets
release/v3.1.0-amber-webui. Once validated and merged, PR #176 (release/v3.1.0-amber-webui->main) will carry these fixes into the v3.1.0 release candidate.Refs: NCE-15, NCE-18, NCE-23, NCE-26