Repository navigation
Add CreditCard faker with comprehensive test data generation - #25
Merged
Merged
Conversation
Introduces a new CreditCard faker that generates realistic credit card test data including: - Card numbers with valid Luhn checksums for all major card types - CVV codes (3 digits standard, 4 for Amex) - Expiration dates (future and expired) - Cardholder names in uppercase format - Issuing bank names - Masked card numbers for display - Network name lookup The implementation delegates to Finance.creditCard() for Luhn validation while providing a dedicated API with expanded functionality beyond the existing Finance methods. All 18 tests pass. Includes specification documentation and learnings from implementation mistakes to help future contributors.
Pull Request Test Coverage Report for Build 21816642455Details
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Introduces a new
CreditCardfaker that generates realistic credit card test data for e-commerce checkout testing, payment gateway integration, and PCI compliance scenarios.Key features:
**** **** **** 1234)Implementation approach:
Finance.creditCard()for Luhn validationEnFile.javafor YAML data loadingFiles changed:
CreditCard.javaprovider class (224 lines)credit_card.ymldata file with card patterns and bank namesCreditCardTest.javawith 18 comprehensive testsFaker.javato register the providerEnFile.javato load YAML dataLEARNINGS.mddocumenting common mistakes for future contributorsCREDITCARD_FAKER_SPEC.mdwith full feature specificationTest plan
Example usage: