wire up search result sorting - #376
Open
iimpulse wants to merge 1 commit into
Open
Conversation
Implement the four non-default sort options client-side until the search endpoint supports sorting. "Most Relevant" stays as the order the API returned - the sort is non-mutating so switching back restores it. Identifiers compare with numeric collation so unpadded ids (NCBIGene:2 vs NCBIGene:10) order correctly. Sorted results are recomputed only on data load, tab change and sort change rather than in a getter, to avoid re-sorting on every change detection pass. Adds Jest coverage for the ordering rules and a stubbed Cypress spec for the dropdown wiring. jsdom has no ResizeObserver, which p-tablist binds in ngAfterViewInit, so test-setup gets a no-op stub. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement the four non-default sort options client-side until the search endpoint supports sorting. "Most Relevant" stays as the order the API returned - the sort is non-mutating so switching back restores it.
Identifiers compare with numeric collation so unpadded ids (NCBIGene:2 vs NCBIGene:10) order correctly. Sorted results are recomputed only on data load, tab change and sort change rather than in a getter, to avoid re-sorting on every change detection pass.
Adds Jest coverage for the ordering rules and a stubbed Cypress spec for the dropdown wiring. jsdom has no ResizeObserver, which p-tablist binds in ngAfterViewInit, so test-setup gets a no-op stub.