This repository was archived by the owner on Jul 21, 2026. It is now read-only.
G3 733 fix null symbol 500 on geneset values cross species - #109
Merged
francastell merged 2 commits intoMar 12, 2026
Merged
Conversation
…ping
Genes with no matching ortholog were returned with ode_ref_id=None,
causing Pydantic serialization failures (500) on /values and silent
null symbol corruption on /{id} and /file endpoints.
…12.3 Unit tests cover filtering of null ode_ref_id entries in both get_geneset_gene_values and get_geneset_w_gene_id_type, including mixed and all-null scenarios. Also fixes pre-existing test that relied on broken cross-species homolog mock behavior.
Test Coverage Report |
desais-jax
approved these changes
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.