fix(backend): no-op vinegar throws after same-tick dethrone - #169
Open
Logiar wants to merge 1 commit into
Open
Conversation
Author
|
Hmm. I focused on preventing multiple mult removals, but the way I read your response in the thread about the issue the following throws after the first successful knockdown shouldn't be processed at all. I'll change what I've done and go by that logic instead. |
Logiar
marked this pull request as draft
February 27, 2026 07:58
Logiar
force-pushed
the
fix_grapes_sympathy_patch
branch
3 times, most recently
from
February 27, 2026 08:53
0a78427 to
8ad06c4
Compare
Logiar
marked this pull request as ready for review
February 27, 2026 08:56
Author
|
Okay, think I'm happy with it now. Changed it so the event shouldn't be processed if the throws target someone who was already successfully thrown.
But it always selects the top ranked and the ranking recalculations are done after events are handled. I figured this was the safest approach for now since with a recalculation would be a major change. |
Logiar
changed the title
Track dethroned targets per handleEvents cycle so repeated queued throws against an already-dethroned top target are no-ops and only first dethrone removes multi. Inline dethroned-target checks in throw handling and keep regression coverage for same-target same-tick and separate tick-set behavior.
Logiar
force-pushed
the
fix_grapes_sympathy_patch
branch
from
June 13, 2026 08:54
8ad06c4 to
bd36ade
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Track dethroned targets per handleEvents cycle so repeated queued throws against an already-dethroned top target are no-ops and only first dethrone removes multi.