Repository navigation
fix(web): open the command palette with Ctrl/Cmd+Shift+K - #971
Closed
thedancingdeveloper wants to merge 1 commit into
Closed
thedancingdeveloper wants to merge 1 commit into
thedancingdeveloper wants to merge 1 commit into
Conversation
Firefox claims bare Ctrl+K ("Search the web") in its own shortcut layer
and never delivers the keydown to the page, so preventDefault on the
app listener cannot win it. Ctrl/Cmd+Shift+K is not reserved by Firefox
or by Chrome's omnibox, and xterm only claims unmodified Ctrl+letter, so
a focused terminal still lets the chord through.
Contributor
Author
|
Closing to fold into the single integration PR (integrate/vogt-next) per operator: one large PR to reduce CI runs. Branch kept; review continues on the branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
preventDefaulton the window listener never ran.Go to…), the shortcut help registry, and the user-guide keyboard table all name the new chord. The registry test asserts Shift+Ctrl+K matches and bare Ctrl+K does not.Test plan
pnpm testinweb/— 138 files, 1149 tests passed