Repository navigation
WI-1080: Python test disposition ledger and coverage gate (I5) - #1087
Merged
Merged
Conversation
…(WI-1080) The ledger retires ruff and mypy in favour of cargo fmt and clippy, and says they still run until the Python package goes. Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com> Signed-off-by: sprooty <sprooty@sprooty.com>
Port the digest and economics op tests, which the Rust operations already cover. Defer the four forge rows that WI-1745 names as blocked on unported services. Name the owner of every other unported row as the work item it is deferred to. Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com> Signed-off-by: sprooty <sprooty@sprooty.com>
…fig (WI-1080) The unknown-caller test read VOGT_* settings while a config test had set VOGT_RETENTION_DAYS to 1_000 in the shared process env, so it failed on the runner. Take the same lock the config tests use. Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com> Signed-off-by: sprooty <sprooty@sprooty.com>
An unported row is a deferral to a named work item, and the disposition test now refuses one without "Deferred to WI-<n>". The economics parser cases go to WI-1765, the profile row to WI-1306, forge publish to WI-1072. Adds the missing-transcript economics case so the session.economics row lists only what the Rust tests pin. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…(WI-1080) The rust-core run on PR #1087 failed in three places that this branch does not touch, so they were inherited from rust-core: - mypy --strict: tests/test_rust_schemas.py typed the registry dumps as object and needed type-ignores that the strict check then flagged as unused; scripts/parity.py reused a dict-typed name for a JSON reply. Type the dumps as Any and give the reply its own name. - the core-alone job deletes engine/, and tests/test_engine_image_core.py reads engine/Dockerfile. Skip that module when the engine tree is absent. - parity: the runner's git 2.54 prints "(null)" for the unresolvable gitdir in the broken fixture, where git 2.53 prints the path. Map the newer spelling to the golden's <root>/nowhere token in the normaliser. Signed-off-by: sprooty <sprooty@sprooty.com> Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com> Signed-off-by: sprooty <sprooty@sprooty.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Settles every
tests/test_*.pyfor the Rust port (WI-1080).docs/PYTHON_TEST_DISPOSITION.md: 124/124 rows. Each row is ported, retired with a reason, or unported and deferred to a named work item. The operator accepted deferral as a disposition.disposition.rsnow fails any unported row that lacksDeferred to WI-<n>.session.economicstest.rust-core.ymlgoes from 70% to 79%. That is the measured 79.72% line coverage, rounded down (operator decision).session_committest race by holdingconfig::env_lock.Verified locally at 64a6bc5:
cargo fmt --check,clippy -p vogt-core --all-targets -D warnings, andcargo test -p vogt-core(916+15 passed) all pass; llvm-cov measures 79.72%. In-process only; nothing was deployed.🤖 Generated with Claude Code