Skip to content

Rust port: engine adapter omits empty account/companion on session create (WI-1064) #1080

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thedancingdeveloper merged 1 commit into from
Oct 17, 2026
Merged

Rust port: engine adapter omits empty account/companion on session create (WI-1064) #1080

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 15 additions & 2 deletions engine/core/src/adapters/engine.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,10 +145,11 @@ impl EngineClient {
if let Some(work_item) = &spec.work_item {
body.insert("work_item".to_string(), Value::String(work_item.clone()));
}
if let Some(account) = &spec.account {
// An empty account or companion is left off, as the Python client does.
if let Some(account) = spec.account.as_ref().filter(|text| !text.is_empty()) {
body.insert("account".to_string(), Value::String(account.clone()));
}
if let Some(companion) = &spec.companion {
if let Some(companion) = spec.companion.as_ref().filter(|text| !text.is_empty()) {
body.insert("companion".to_string(), Value::String(companion.clone()));
}
// Policy and worktree are sent only when they carry something, as the
Expand Down Expand Up @@ -2434,6 +2435,18 @@ mod tests {
assert!(!sent.contains("worktree"));
}

#[test]
fn create_session_leaves_out_an_empty_account_or_companion() {
let (seen, transport) = scripted(200, r#"{"id":"s","name":"n","cwd":"/proj"}"#);
let mut spec = CreateSession::new("n", "/proj");
spec.account = Some(String::new());
spec.companion = Some(String::new());
client(transport).create_session(&spec).unwrap();
let sent = &seen.lock().unwrap()[0];
assert!(!sent.contains("account"));
assert!(!sent.contains("companion"));
}

#[test]
fn create_session_sends_a_policy_and_worktree_that_carry_something() {
let (seen, transport) = scripted(200, r#"{"id":"s","name":"n","cwd":"/proj"}"#);
Expand Down
Loading