Repository navigation
parity: re-record 21c95f6 golden for decision/preference/inbox steps - #1074
Merged
Merged
Conversation
…steps (WI-1069) The committed cli, http and mcp goldens predate the decision, preference and inbox steps added to tests/parity/script.json by WI-1069, so the parity job's committed-golden check failed on those steps. Re-record all three transports from the Python core at the merge-base with origin/main (21c95f6), as docs/rust-port/drift-triage-2026-10-16.md describes. Only golden files change; the recorded steps already in the golden are unchanged. Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com> Signed-off-by: sprooty <sprooty@sprooty.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tests/parity/golden/21c95f6cli, http and mcp goldens from the Python core. They were missing the decision, preference and inbox steps that WI-1069 added totests/parity/script.json, which turned the parity job red (run 39010185327 at b2c3d08).meta.jsontimestamp).Verification
Run from this branch, using the same commands the parity job runs (
.github/workflows/rust-core.yml):check --impl python(cli): 110 steps agree.check --impl python --transport http: 46 steps agree.check --impl rust --transport http: 46 steps agree.check --impl rust --only dump: agrees.check --impl python --only actor: 2 steps agree.selftest: passes.check --impl python --transport mcpandcheck --impl rust --transport mcp, both 110 steps agree.check --impl rust(cli, default transport): 110 steps agree.Notes
git merge-base origin/rust-core origin/mainis still21c95f6.origin/mainhas moved on since the base, but that does not change the golden name because the branch is based on21c95f6.🤖 Generated with Claude Code