Repository navigation
feat(core): port decision.* and its Inbox row; S4 gap close (WI-1069) - #1073
Merged
Merged
Conversation
Ports decision.ask, decision.answer, decision.list and decision.withdraw from application/services/decisions.py. A person answers; an agent asks, and a pending decision past its expiry reads `expired` with no implied answer. The Inbox shows each pending decision as a decision.pending entry. Adds the Decision entity, its storage (migration 0023_decisions) and the ported test_decisions.py cases in application/services/decisions_test.rs. SequentialIds in the test is persisted, and each action opens its own context, because an in-memory counter over a shared directory collides. Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com> Signed-off-by: sprooty <sprooty@sprooty.com>
…WI-1069) Adds ten decision.ask/list/answer/withdraw steps to tests/parity/script.json and records tests/parity/golden/21c95f6-s4 (cli, http, mcp) from the Python implementation, the authority. The Rust core agrees on every step. The decision service now reads the step clock as Python does: once per row when it lists, twice in the answer body, and once for each write's view. The MCP driver shares one process across steps, so the read count shifts every later timestamp when it is wrong. Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com> Signed-off-by: sprooty <sprooty@sprooty.com>
…er (WI-1069) Two refusal steps for preference.set inbox.filter (an unknown source, an unknown field) and a read-back, so the B5 blocker on refused filter values is held by the parity harness. Golden 21c95f6-s4 re-recorded from Python for cli, http and mcp; the Rust core agrees on every step. Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com> Signed-off-by: sprooty <sprooty@sprooty.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes the S4 gaps from docs/rust-port/gap-audit-2026-10-17.md for WI-1069.
Review (head 0085db1): no blockers. Gates:
All of this ran in-process only. The branch merges cleanly onto rust-core 360cd67.
Note: S-branches all append to the end of script.json and each records its own 21c95f6-sN golden. Re-record the golden after each one merges.
🤖 Generated with Claude Code