Skip to content

Delivery: retry Enter while a resumed Codex still holds the text (WI-1669) - #1053

Merged
thedancingdeveloper merged 2 commits into
mainfrom
wi-1669-composer-held
Oct 16, 2026
Merged

thedancingdeveloper merged 2 commits into
mainfrom
wi-1669-composer-held

Conversation

@thedancingdeveloper

Copy link
Copy Markdown
Contributor

A resumed Codex could keep the submitted text in its composer while Vogt reported it as delivered. The check now reads the composer line above the footer. It retries Enter up to 3 times until a turn starts, and never presses Enter while a dialog is showing. The tests use screens captured from a live Codex session. Opus review: no blockers at 27a69e7.

🤖 Generated with Claude Code

sprooty and others added 2 commits October 16, 2026 10:49
…ed (WI-1669)

A resumed Codex can read as running while the Enter was swallowed and
the text still sits after its prompt. judge() now takes the submitted
text for Codex and calls the latest read unconfirmed while the composer
(the last line starting with the Codex prompt) still shows it, so the
one-time Enter retry fires and the final verdict checks the composer too.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: sprooty <sprooty@sprooty.com>
…nly on its composer (WI-1669)

Review blockers on 408f8d6:
- Up to 3 Enters in all, each further one after a readiness wait, stopping
  as soon as a turn starts or the composer clears.
- The composer is the prompt block drawn directly above Codex's
  model/directory footer; a transcript copy or a dialog's highlighted
  choice (same glyph) never counts. No Enter while an approval or dialog
  shows or when no composer is drawn.
- Fixtures captured live from a hibernated-then-resumed Codex
  v0.162.0: the swallowed Enter (running, text held, 'tab to queue
  message'), the stuck ready state 4 s later, and the screen after the
  next Enter landed. The approval dialog is the one synthetic fixture.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: sprooty <sprooty@sprooty.com>
@thedancingdeveloper
thedancingdeveloper enabled auto-merge (rebase) October 16, 2026 11:12
@thedancingdeveloper
thedancingdeveloper merged commit 173ec92 into main Oct 16, 2026
15 checks passed
@thedancingdeveloper
thedancingdeveloper deleted the wi-1669-composer-held branch October 16, 2026 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant