Repository navigation
engine: handle the Codex folder-trust startup gate (WI-1667) - #1034
Merged
Merged
Conversation
added 2 commits
October 15, 2026 23:05
Codex's "Trust this folder?" screen was not a dialog the engine could answer, and typing "1" into it exited the session. Detect it as a folder-trust startup gate, and record trust_level = "trusted" for the session's own cwd before Codex starts.
Presence is decided on the parsed document, so a project already recorded under any TOML spelling is left alone instead of getting a duplicate table that would make the config invalid. The edit is re-parsed before it is written, and the "Quit" variant of the trust gate is covered.
thedancingdeveloper
enabled auto-merge (rebase)
October 15, 2026 23:33
warm_attach_within_budget_stays_a_byte_exact_delta read the cursor as soon as the priming bytes reached the socket, which is before the PTY reader commits them to the ring. The resume then included them and failed CI on an unrelated change. Wait until the recorded position has moved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Detects Codex's 'Trust this folder?' gate and pre-trusts only the session's own engine worktree. The re-review found no blockers (handoff on WI-1667).
🤖 Generated with Claude Code