Fix #1117 - Navbar causes session creation in a stateless f:view - #1118
Closed
exabrial wants to merge 1 commit into
Closed
Fix #1117 - Navbar causes session creation in a stateless f:view#1118exabrial wants to merge 1 commit into
exabrial wants to merge 1 commit into
Conversation
…static concurrent map instead of the server session
Contributor
Author
|
The only downside to this approach is that if the lifecycle is stopped between the static call to |
Contributor
Author
|
Hey guys, has anyone had time to evaluate this? thank you |
geopossachs
self-requested a review
January 28, 2020 18:12
Collaborator
|
i would rather not like to keep data in a listner. i think but we can use the attributes of the components. I have prepared a pr on your idea. please check if this would work for sessionless. I would reject this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Navbar causes session creation. Use a private static concurrent map instead of the server session