Skip to content

Fix #1117 - Navbar causes session creation in a stateless f:view - #1118

Closed
exabrial wants to merge 1 commit into
TheCoder4eu:masterfrom
exabrial:issues/1117_Navbar-causes-session-creation
Closed

Fix #1117 - Navbar causes session creation in a stateless f:view#1118
exabrial wants to merge 1 commit into
TheCoder4eu:masterfrom
exabrial:issues/1117_Navbar-causes-session-creation

Conversation

@exabrial

Copy link
Copy Markdown
Contributor

Navbar causes session creation. Use a private static concurrent map instead of the server session

…static concurrent map instead of the server session
@exabrial exabrial changed the title WIP: Fix #1117 - Navbar causes session creation Fix #1117 - Navbar causes session creation Jan 14, 2020
@exabrial exabrial changed the title Fix #1117 - Navbar causes session creation Fix #1117 - Navbar causes session creation in a stateless f:view Jan 14, 2020
@exabrial

Copy link
Copy Markdown
Contributor Author

The only downside to this approach is that if the lifecycle is stopped between the static call to addResource and the system event firing, you'll have a key stuck in the map, resulting in a memory leak. This may or may not be possible under the JSF lifecycle, I actually don't know enough about it to make a good judgement call.

@exabrial

Copy link
Copy Markdown
Contributor Author

Hey guys, has anyone had time to evaluate this? thank you

@geopossachs
geopossachs self-requested a review January 28, 2020 18:12
@geopossachs

Copy link
Copy Markdown
Collaborator

i would rather not like to keep data in a listner. i think but we can use the attributes of the components. I have prepared a pr on your idea. please check if this would work for sessionless. I would reject this

#1123

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants