Czhu update novel orf#16
Merged
Merged
Conversation
… circRNA readthrough=3 when no downstream stop is found
There was a problem hiding this comment.
Pull request overview
This PR standardizes novel-ORF peptide FASTA headers to use coordinate-style ORF IDs and a canonical token order consistent with circRNA peptide headers, updating both generation and parsing paths plus associated tests/docs.
Changes:
- Generate non-circ ORF IDs in
ORF-START:ENDform (when transcript sequence is available) and serialize ORF tokens before variant tokens. - Keep backward-compatible parsing for prior token orders while normalizing
__str__output to the canonical order. - Update unit tests, documentation, and test fixture FASTA/table files to match the new header conventions.
Reviewed changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
moPepGen/svgraph/PeptideVariantGraph.py |
Adds linear stop-codon caching + linear ORF stop inference and emits coordinate-style ORF IDs; updates circ no-stop readthrough behavior. |
moPepGen/aa/VariantPeptideIdentifier.py |
Updates parsing examples and normalizes serialization order (ORF before variants); improves gene token inference for novel-ORF-only headers. |
moPepGen/pipeline/call_variant_workers.py |
Passes tx_seq and codon_table into peptide calling so linear ORF IDs can be computed. |
moPepGen/pipeline/call_novel_orf_worker.py |
Passes tx_seq and codon_table into peptide calling for novel ORF workflows. |
test/unit/test_peptide_variant_graph.py |
Adds/updates tests for linear ORF coordinate IDs and circRNA no-stop sentinel behavior. |
test/unit/test_variant_peptide_id.py |
Adds parsing/roundtrip tests for canonical ORF-before-variant ordering and legacy order compatibility. |
test/unit/test_peptide_pool_summarizer.py |
Updates expected header ordering and adds coverage for novel ORF coordinate headers. |
test/unit/test_peptide_pool_splitter.py |
Updates expected header ordering and adds split coverage for novel ORF coordinate headers and mixed-label inputs. |
docs/file-format.md |
Documents the non-circ novel ORF header style and coordinate ORF ID notation. |
test/files/peptides/variant_peptide_table.txt |
Updates fixture content to align with new ORF/header conventions (ordering/IDs). |
test/files/peptides/variant.fasta |
Updates fixture FASTA headers/order to match new conventions. |
test/files/peptides/novel_orf.fasta |
Updates novel ORF fixture FASTA headers to coordinate-style ORF IDs and revised ordering. |
test/files/peptides/alt_translation.fasta |
Updates fixture FASTA to match revised header formatting/order. |
CHANGELOG.md |
Notes the novel-ORF header format changes and backward-compatible parsing behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…d correct FASTA header comment typo ("Optional") in VariantPeptideIdentifier
…OP and READTHROUGH=3 indicates no in-frame stop found within the search window
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The Novel ORF peptide fasta header now follow the same format as the circRNA peptides.
Example:
Closes #...
Checklist
.png, .jpeg),.pdf,.RData,.xlsx,.doc,.ppt, or other non-plain-text files. To automatically exclude such files using a .gitignore file, see here for example.CHANGELOG.mdunder the next release version or unreleased, and updated the date.