refactor(xcb): type-safe core event dispatch - #14
Merged
Conversation
Add libxcb/include/xcb/event_dispatch.hpp mirroring the MessageTraits + X-macro pattern from libipc/message_dispatch.hpp: one X-macro enumerates core X11 event structs and their opcodes, EventTraits<T> exposes the opcode at compile time, and dispatch_event() drives a single switch that routes to handler.on(T&) overloads via a KnownEvent-constrained concept. Migrate both consumers: - X11Backend::handle_generic_event (backends/x11) - XWindowManager::dispatch (libwlserver/xwm) Both use a thin adapter struct (X11EventHandler / XwmEventHandler) that forwards typed events to existing handle_* methods, marked TODO — the cleaner end state is to let the class itself satisfy the dispatch concept, blocked by a name clash with Backend::on(event::...) virtuals. Also add event_as<T>() for intention-revealing casts from xcb_generic_event_t* in loop.cpp's motion/expose coalescing. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
libxcb/include/xcb/event_dispatch.hpp: X-macro +EventTraits<T>+KnownEventconcept +dispatch_event(). Mirrors theMessageTraitspattern fromlibipc/message_dispatch.hpp.X11Backend::handle_generic_eventandXWindowManager::dispatchto use it; the big manual opcode switch is gone from both.xcb::event_as<T>for typed casts fromxcb_generic_event_t*in the motion/expose coalescer.Notes
Each dispatch site uses a small adapter struct (
X11EventHandler/XwmEventHandler) marked// TODO: temporary. The cleaner end state is to let the class itself satisfy the concept viaon(xcb_*_t&), which is currently blocked by a name clash withBackend::on(event::...)virtuals (-Woverloaded-virtual).Test plan
-DSIRENWM_BACKEND=wayland, wlserver target)ctestgreen (core, runtime, modules)🤖 Generated with Claude Code