Repository navigation
fix: bound lexicographic permutation input - #1594
Open
wjc2821296948 wants to merge 1 commit into
Open
wjc2821296948 wants to merge 1 commit into
wjc2821296948 wants to merge 1 commit into
Conversation
Co-Authored-By: chaogeshuodiannao <chaogeshuodiannao@users.noreply.github.com>
wjc2821296948
requested review from
Panquesito7,
alexpantyukhin and
tjgurwara99
as code owners
October 12, 2026 12:56
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the input buffer handling in
misc/lexicographic_permutations.c.The program allocated exactly
nbytes for an input of up toncharacters, leaving no room for the terminating null byte, and used an unbounded%sconversion. The buffer now reservesn + 1bytes, checks allocation/input failures, and constructs a bounded%nsformat from the validated input size.Compiled with C11 warnings enabled and verified with a 3-character permutation input.
Refs #960