Repository navigation
Conversation
tianrking
requested review from
Panquesito7,
alexpantyukhin and
tjgurwara99
as code owners
October 4, 2026 20:43
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Fix the right-heavy rebalancing conditions in AVL deletion. When the right child has balance -1, deletion currently selects a right-left rotation; when its balance is +1, deletion selects a single left rotation. These choices are reversed. For example, inserting
2, 1, 4, 5and deleting1selects a rotation whose required child is absent, while inserting2, 1, 4, 3and deleting1leaves the tree unbalanced.Use a single left rotation for right-child balance <= 0 and a right-left rotation for balance > 0. Add self-tests before the existing interactive example: six deletion rotation cases, sixteen deterministic insertion/deletion permutations, duplicate and missing-key operations, and signed key boundaries. Each mutation checks BST ordering, actual versus stored height, AVL balance, and the expected node set/count.
References
Validation on a public fork using standard Ubuntu 24.04 runners:
AnalyzeTemporaryDtorsconfiguration field; the repository's configured checks and warnings-as-errors remain enabled.The validation workflow and probe are separate from this PR.
Checklist
Notes: Existing AVL deletion now chooses the correct single or double rotation for a right-heavy subtree.