Reliability sweep: nav-collisions + opaque failures + dead-ends (v1.121.5) - #73
Merged
Conversation
…(v1.121.5) Codebase-wide audit of the systemic bug class the user kept hitting. - [M] Manual is matched before the navigation check in Select-PhysicalAdaptersSmart (09-SET) and Set-iSCSIConfiguration (10-iSCSI); "m" (the home token) no longer swallows the Manual option. - Opaque failures surfaced: SNMP Restart-Service / Remove-ItemProperty and pagefile Remove-CimInstance in 55-QoLFeatures, and the PSGallery-trust step in 14-WindowsUpdates, no longer print success on a silenced failure. - Silent dead-ends now give feedback: 33-StorageReplica install prompt and the RDP/WinRM subnet-restriction prompts (15-RDP). - Tests: new Run-Tests Section 192; the "Read-Host Select has nav" meta-test now accepts the correct keys-first ordering. Version bump to 1.121.5. Deliberately NOT changed (per the audit's false-positive list): the dead [M] switch arms (harmless dead code; [M] works via the home handler) and the agent-search boxes (intercepting nav tokens there is defensible UX).
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Codebase-wide sweep of the systemic bug class. Fixes the [M] Manual collision in SET adapter + iSCSI menus (m=home token), surfaces silenced SNMP/pagefile/PSGallery failures, and adds feedback to silent dead-ends (Storage Replica, RDP/WinRM subnet prompts). Deliberately skips harmless dead [M] arms and the defensible agent-search nav handling. Suite 5269/5269, PSSA 0.