S22 — A player does not start from nowhere - #101
Merged
Conversation
Author 3 starting backgrounds (kitchen hand, office temp, overqualified graduate) and 3 traits, one granted by each background. Each background differs in starting skills and starting credentials; traits resolve in both directions (S22.4). Regenerate the published export. Resolves the buildPlayer backgrounds[0] blocker noted under S16.3's findings — createGame no longer indexes an empty array for this campaign.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Authors the last two of
SimulationCampaignSource's seventeen collections — 3 startingbackgrounds and 3 traits, one granted by each.
BackgroundDefinitionturns out to carry nostarting-items field at all (
03§8.10 places starting inventory on the scenario, not thebackground), so S22.2/S22.3's "starting items" language is satisfied via skills/credentials
instead of being approximated. This also resolves the
buildPlayerbackgrounds[0]indexingblocker noted under S16.3's findings —
createGameno longer throws for this campaign.Closes #90
Verified
All 9 discovered gates ran and passed. Nothing failed; nothing did not run.
Ran and passed:
*.ps1files parsed withSystem.Management.Automation.Language.Parser, zero parse errors.Invoke-Pester -Path tools -Output Detailed -PassThru: 350/350 passed, 0 failed, 0 skipped, 208.55s../tools/Test-Companion.ps1: 23 core(s) checked, 0 companion files present, State: Valid, exit 0../tools/Test-DesignState.ps1: 0 findings; 26 non-blockingMirrorStaleentries underdesign/state/work/*(this branch's commit hasn't been through/trackyet, expected); 0 could-not-evaluate; exit 0../tools/Test-SpecSet.ps1: Valid; 8 documents; 936 declarations; 8 references correctly reported unresolvable (cross-repository, intoSubZeroDev.GameEngine); exit 0.npm run setup:npm ci+tsc -p tsconfig.build.jsonfor the engine submodule, exit 0.npm run typecheck:tsc --noEmit, no output, exit 0.npm test:vitest run, Test Files 4 passed (4), Tests 49 passed (49), exit 0 — includes the new "Stable Life — backgrounds and traits (S22)" suite, verified to fail for the right reason (emptybackgrounds/traits) before the content existed.npm run export:content && npm run check:clean: "Exported 1 campaign(s) to content/", then "content/ matches the sources.", exit 0.Ran and failed: none.
Did not run: none.
Agent detail
design/30-slices.md§ S22 @1ec3337099d3ad2b763987c14cef6cdd67e2b05a