Context
.github/workflows/docs-ci.yml's verify job (the required "Verify Documentation Build" check) runs in the docs-template Alpine container. That container has no apt-get, so playwright install --with-deps chromium failed outright there (sh: apt-get: not found) on every run — see PR #201, commit cc216e8.
The fix installs Chromium via apk add --no-cache chromium instead, and points site/vitest.browser.config.ts at it via PLAYWRIGHT_CHROMIUM_EXECUTABLE_PATH. That unblocks the check, but the apk add step itself is uncached: it pulls ~760 MiB across 171 packages on every single run of this required check, adding roughly a minute of avoidable time.
Ask
Cache the Alpine package set (or the resulting /usr/bin/chromium-browser + its shared-library closure) across runs of the verify job in docs-ci.yml, the same way engine's npm dependencies are already cached via actions/setup-node's cache: npm. A docker-layer cache on the docs-template:latest pull, or an actions/cache step keyed on the Alpine package versions, would both work — whichever fits the container-job model best.
Origin
Raised by qodo-code-review on PR #201 against the original (now-superseded) playwright install --with-deps step; re-filed here against the apk-based replacement since the underlying "no caching on a required check" concern still applies to the new step, just not to the exact line the original comment pointed at.
Context
.github/workflows/docs-ci.yml'sverifyjob (the required "Verify Documentation Build" check) runs in thedocs-templateAlpine container. That container has noapt-get, soplaywright install --with-deps chromiumfailed outright there (sh: apt-get: not found) on every run — see PR #201, commit cc216e8.The fix installs Chromium via
apk add --no-cache chromiuminstead, and pointssite/vitest.browser.config.tsat it viaPLAYWRIGHT_CHROMIUM_EXECUTABLE_PATH. That unblocks the check, but theapk addstep itself is uncached: it pulls ~760 MiB across 171 packages on every single run of this required check, adding roughly a minute of avoidable time.Ask
Cache the Alpine package set (or the resulting
/usr/bin/chromium-browser+ its shared-library closure) across runs of theverifyjob indocs-ci.yml, the same wayengine's npm dependencies are already cached viaactions/setup-node'scache: npm. Adocker-layer cache on thedocs-template:latestpull, or anactions/cachestep keyed on the Alpine package versions, would both work — whichever fits the container-job model best.Origin
Raised by
qodo-code-reviewon PR #201 against the original (now-superseded)playwright install --with-depsstep; re-filed here against theapk-based replacement since the underlying "no caching on a required check" concern still applies to the new step, just not to the exact line the original comment pointed at.