Skip to content

World-graph: scenery placement has no rotation/bounds validation (unlike buildings) #145

Description

@The-Running-Dev

Summary

initialState in src/engine/src/kinds/world-graph/initial.ts:74-79 places scenery from scenario.sceneryPlacements with no geometry validation — no check that the rotated footprint stays within map bounds or avoids occupied/blocked cells. Building placement, by contrast, goes through checkBuildingPlacement (see initial.ts:42) which does validate this.

Where this came from

Flagged by automated Qodo review as "Validate scenery placement geometry" against PR #124, fixed in never-merged remediation PR #126. Not reapplied during the W46-W49 rewrite — confirmed still present against current main.

Suggested fix

Apply the same placement-geometry validation used for buildings (bounds + occupancy check against the rotated footprint) to scenery placements, either in initial.ts or as a Tier-1/2 rule in validate.ts.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions