Sta latest 0710#388
Conversation
commit 4075953c9798444b9d5275f8fa0320f74b9bf1ef
Author: James Cherry <cherry@CerezoBook.local>
Date: Sat Jul 4 09:00:48 2026 -0700
bfs resort hasNext
Signed-off-by: James Cherry <cherry@CerezoBook.local>
commit 4fb0dd19e479f507935129fe940bcd1cf93b29d0
Author: James Cherry <cherry@CerezoBook.local>
Date: Thu Jul 2 12:23:54 2026 -0700
ApiChanges
Signed-off-by: James Cherry <cherry@CerezoBook.local>
commit 510afbc1403c9fd2b764b4f3a71dddabd696f052
Author: James Cherry <cherry@CerezoBook.local>
Date: Thu Jul 2 11:07:44 2026 -0700
bfs enqueueFanin/out
Signed-off-by: James Cherry <cherry@CerezoBook.local>
commit 9a5aa570e910c289b276a519bdf532dfa2e28c5f
Author: James Cherry <cherry@CerezoBook.local>
Date: Thu Jul 2 10:41:27 2026 -0700
Revert "bfs continueFrom/enqueueFanin/out"
This reverts commit d18498c947a7df2b615fafda38fbdbe8033eca9d.
commit 02a253ab252f6637cfea29bdd788cb25da16813d
Author: James Cherry <cherry@CerezoBook.local>
Date: Thu Jul 2 08:21:49 2026 -0700
Revert "Bfs rm search_pred"
This reverts commit d858b3380b5e1d81ff6162b6378672a6099a246f.
commit 0adf03613d91c5774545d12cba1dc52052ca732a
Author: James Cherry <cherry@CerezoBook.local>
Date: Thu Jul 2 08:08:04 2026 -0700
Genclks::ensureMaster
Signed-off-by: James Cherry <cherry@CerezoBook.local>
commit 089b373c548b77f9189a2617c3168867de620dfe
Author: James Cherry <cherry@CerezoBook.local>
Date: Wed Jul 1 17:50:43 2026 -0700
Search::ensureDownstreamClkPins() use dfs
Signed-off-by: James Cherry <cherry@CerezoBook.local>
commit 000ca16adb9bdcb92266e5f242629bc3e8612658
Author: James Cherry <cherry@CerezoBook.local>
Date: Wed Jul 1 10:03:57 2026 -0700
ApiChangeLog
Signed-off-by: James Cherry <cherry@CerezoBook.local>
commit d858b3380b5e1d81ff6162b6378672a6099a246f
Author: James Cherry <cherry@CerezoBook.local>
Date: Wed Jul 1 09:56:53 2026 -0700
Bfs rm search_pred
Signed-off-by: James Cherry <cherry@CerezoBook.local>
commit d18498c947a7df2b615fafda38fbdbe8033eca9d
Author: James Cherry <cherry@CerezoBook.local>
Date: Wed Jul 1 08:07:15 2026 -0700
bfs continueFrom/enqueueFanin/out
Signed-off-by: James Cherry <cherry@CerezoBook.local>
commit a8c55b12b3ad7a1041766775727ad758ae8c6d18
Author: James Cherry <cherry@CerezoBook.local>
Date: Tue Jun 30 10:07:46 2026 -0700
bfs continue
Signed-off-by: James Cherry <cherry@CerezoBook.local>
commit 8530dcd86b7ee736f1858143c3b2cee57cdbc991
Author: James Cherry <cherry@CerezoBook.local>
Date: Tue Jun 30 07:15:28 2026 -0700
Graph::visitFanin/out uninline edge iter
Signed-off-by: James Cherry <cherry@CerezoBook.local>
commit 1ba1f4576f4b72c64db742369a63dcf8726ba002
Author: James Cherry <cherry@CerezoBook.local>
Date: Mon Jun 29 21:09:17 2026 -0700
BfsIterator rm Iterator<Vector> subclass
Signed-off-by: James Cherry <cherry@CerezoBook.local>
commit b3ddd2580298958ad6da8225ecac0d255315504c
Author: James Cherry <cherry@CerezoBook.local>
Date: Mon Jun 29 20:15:23 2026 -0700
ClkNetwork::findClkPins use VertexQueue instead of bfs
Signed-off-by: James Cherry <cherry@CerezoBook.local>
commit 9e73154db48a7301be4039a25aec1fef589ef18a
Author: James Cherry <cherry@CerezoBook.local>
Date: Mon Jun 29 18:39:39 2026 -0700
Search::ensureDownstreamClkPins use VertexQueue
Signed-off-by: James Cherry <cherry@CerezoBook.local>
commit 9cd1b160e126ccacc47375ef508fdbb580bfa162
Author: James Cherry <cherry@CerezoBook.local>
Date: Mon Jun 29 11:18:03 2026 -0700
comment
Signed-off-by: James Cherry <cherry@CerezoBook.local>
commit 0baf3838e2b8faa5fea560b0c95431b277631fea
Author: James Cherry <cherry@CerezoBook.local>
Date: Mon Jun 29 10:57:39 2026 -0700
findClkArrivals use invalid for clk fringe
Signed-off-by: James Cherry <cherry@CerezoBook.local>
commit e82ccd10a5e4bd69e41ce889685d7a130ae79ed6
Author: James Cherry <cherry@CerezoBook.local>
Date: Sun Jun 28 20:36:48 2026 -0700
Search::findClkArrivals
Signed-off-by: James Cherry <cherry@CerezoBook.local>
commit cb66a72686c8728141c72ceb593b8a4b895ff696
Author: James Cherry <cherry@CerezoBook.local>
Date: Sun Jun 28 10:11:55 2026 -0700
rm Search::postponeClkFanouts
Signed-off-by: James Cherry <cherry@CerezoBook.local>
Signed-off-by: James Cherry <cherry@CerezoBook.local>
Signed-off-by: James Cherry <cherry@CerezoBook.local>
Signed-off-by: James Cherry <cherry@CerezoBook.local>
Signed-off-by: James Cherry <cherry@CerezoBook.local>
…Mode properties extensible (#456) * support for filter in get_scene/mode Signed-off-by: dsengupta0628 <dsengupta@precisioninno.com> * defineProperty overload Signed-off-by: dsengupta0628 <dsengupta@precisioninno.com> * define and set user property Signed-off-by: dsengupta0628 <dsengupta@precisioninno.com> * address review comments to generalize- current support for mode and scene Signed-off-by: dsengupta0628 <dsengupta@precisioninno.com> * address second round comments- removed user from cmd names Signed-off-by: dsengupta0628 <dsengupta@precisioninno.com> * remove defaults, check property vals against type defined Signed-off-by: dsengupta0628 <dsengupta@precisioninno.com> * address reviews, indent Signed-off-by: dsengupta0628 <dsengupta@precisioninno.com> * indent fix Signed-off-by: dsengupta0628 <dsengupta@precisioninno.com> --------- Signed-off-by: dsengupta0628 <dsengupta@precisioninno.com>
Signed-off-by: James Cherry <cherry@CerezoBook.local>
Signed-off-by: James Cherry <cherry@CerezoBook.local>
|
James Cherry seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
There was a problem hiding this comment.
Code Review
This pull request introduces support for user-defined, per-object mutable properties on Scene and Mode objects, and adds filtering capabilities via the -filter option in get_scenes and get_modes. Additionally, it refactors BFS/DFS traversal and timing propagation logic, replacing several BFS iterators with standard queues/stacks or specialized fanout/fanin enqueuing methods. However, a critical bug was identified in graph/Graph.cc where VertexOutEdgeIterator was incorrectly used instead of VertexInEdgeIterator in Graph::visitFaninEdges, which will break backward timing propagation.
| for (Edge *edge = this->edge(vertex->in_edges_); | ||
| edge; | ||
| edge = this->edge(edge->vertex_in_next_)) { | ||
| VertexOutEdgeIterator edge_iter(vertex, graph_); |
There was a problem hiding this comment.
In Graph::visitFaninEdges, the iterator has been incorrectly changed to VertexOutEdgeIterator instead of VertexInEdgeIterator. This causes the function to iterate over outgoing edges (fanouts) instead of incoming edges (fanins), which will break backward timing propagation and lead to incorrect slack/required time calculations.
VertexInEdgeIterator edge_iter(vertex, graph_);
Latest changes from upstream OpenSTA 7/10
Has the changes for define_property for user defined property on scene and mode objects along with property based filtering