Make the Map Journal the primary review experience (#14) - #43
Merged
Merged
Conversation
The closing-keyword heredoc was written at column 0 inside the run block scalar, which ended the scalar early and made the workflow file unparseable — every push and pull_request claim run failed with a workflow file issue. Indent the heredoc to the block's base indentation so the script sees it at column 0. Co-authored-by: Will Schenk <wschenk@gmail.com>
Co-authored-by: Will Schenk <wschenk@gmail.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
- /journal renders the installed Offline Region as the review surface with media-aware, clustered Capture markers (circle+text layers, airplane-safe) - Marker selection opens a compact Capture preview with the complete Thread, Enrichments with sources and models, status, and a follow-up composer that uses the ordinary Capture pipeline online or offline - Desktop shows an adjacent Thread panel; mobile a bottom sheet - Live GPS only while the map is active with honest unavailable/accuracy states - Shared thread entry views extracted from the capture composer - Pixel-sized and desktop Playwright coverage incl. airplane mode Co-authored-by: Will Schenk <wschenk@gmail.com>
- Retain Thread Enrichments locally so reviewed Threads stay readable offline - Render the Thread panel as one chronological stream (Enrichments follow their basis revision) with inline local media previews - Follow-up composer accepts media attachments through the ordinary pipeline - Promote the journal as the primary review destination from the home shell - Dedicated Desktop Chrome Playwright project; assert the mobile bottom sheet - Type the journal hook state union and drop the setData never-cast Co-authored-by: Will Schenk <wschenk@gmail.com>
Co-authored-by: Will Schenk <wschenk@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket
Closes #14 — Make the Map Journal the primary review experience (parent #1)
What this PR does
Implements the validated Map Journal (reviewing-ui prototype verdict, variant C — rewritten, not promoted) as the primary review surface at
/journal, linked as the review destination from the home shell.renderInstalledRegion; if no region is installed it offers the explicit download with its calculated size.lib/enrichment/thread-view.ts) so previously reviewed Threads keep them readable offline.Tests
tests/map-journal.spec.ts(Pixel-9 project): offline topography, clustering + media-aware markers, honest GPS states, marker preview with complete Thread context and the mobile bottom sheet, an offline follow-up through the ordinary pipeline, and complete airplane-mode rendering after reload.tests/map-journal-desktop.spec.ts(new dedicated Desktop Chrome project): the adjacent Thread panel layout./journal?region=fixturepage returns 200 on this PR's Vercel Preview.Also carries the
agent-ticket-claimworkflow YAML fix (same as PR #41): the closing-keyword heredoc was written at column 0 inside therun:block scalar, which made the workflow file unparseable since PR #39.Screenshots
To show artifacts inline, enable in settings.