Skip to content

Notify when Enrichment finishes or needs attention (#11) - #37

Merged
cursor[bot] merged 1 commit into
mainfrom
cursor/processing-notifications-1c08
Jul 19, 2026
Merged

cursor[bot] merged 1 commit into
mainfrom
cursor/processing-notifications-1c08

Conversation

@wschenk

@wschenk wschenk commented Jul 19, 2026

Copy link
Copy Markdown
Contributor

Summary

Implements #11: web push after Enrichment completes or newly enters needs attention, with opt-in only after the first successful sync.

Also updates close-shipped-tickets.yml so merging to main closes shipped #10 (API close was blocked for the cloud agent).

What changed

  • Opt-in: After a sync batch with results, the composer explains value and only then offers “Enable notifications” (browser permission is not requested at load).
  • Subscribe API: POST /api/push/subscribe behind requireSyncAccess; Neon/memory push_subscriptions.
  • Notify: Enrichment process sends one push per new Enrichment (completeJob.created) and per needs-attention transition (keyed by job + attempt so retries re-notify once).
  • SW: push + notificationclick; cache bump to v8.
  • Secrets: VAPID keys in fnox / 1Password (NEXT_PUBLIC_VAPID_PUBLIC_KEY, VAPID_PRIVATE_KEY, VAPID_SUBJECT).
  • Tests: tests/push.spec.ts — opt-in timing, completion, failure, duplicate suppression, denial, stale subscriptions, retry re-entry.

Follow-ups for humans

Test plan

  • mise run lint
  • mise run test -- tests/push.spec.ts
  • Preview: sync a Capture, accept notifications, wait for Enrichment complete/fail push
  • Deny notifications: app still syncs/enriches; explanation visible
Open in Web Open in Cursor 

@vercel

vercel Bot commented Jul 19, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
walking-thoughts Ready Ready Preview, Comment Jul 19, 2026 1:49am

Request Review

Rebase onto main with Offline Regions: web push opt-in after first sync,
authenticated subscriptions, deduped complete/needs-attention notifies, and
vercel:sync via VERCEL_TOKEN.

Co-authored-by: Will Schenk <wschenk@gmail.com>
@cursor
cursor Bot force-pushed the cursor/processing-notifications-1c08 branch from e3c0a38 to 4d44641 Compare July 19, 2026 01:48
@cursor
cursor Bot merged commit f1c2f1e into main Jul 19, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants