A dropped brace in globals.css was eating every rule after it - #172
Merged
Conversation
The To-do merge left .todo-tally unterminated, so from that point to the end of the file every rule was parsed as declarations of that block and silently discarded. Nothing errored — the build passed, the pages rendered — but the Day flow and the Field Manual both shipped with no styles at all: no container, no margins, text edge to edge. Restores the brace, which brings back .day-flow and every .manual-* rule. Adds tests/globals-css.spec.ts, because the stylesheet is the one part of this app with no type checker and this failure mode is invisible: it asserts the braces balance, and that each surface's rules (.manual-sheet, .day-flow, .todo-items, .shell) sit at the top level rather than nested inside an earlier block. No-ticket: true Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Mm4zPLAX77USAqyk12jgc1
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Day flow and the Field Manual are both unstyled on
mainright now — no container, no margins, text edge to edge./daysis effectively unusable.Cause: the To-do merge left
.todo-tallyunterminated. From that point to the end of the file, every rule was parsed as declarations of that block and silently discarded —.day-flow(#168) and all 39.manual-*rules (#170) included. Nothing errored: the build passed, the pages rendered, the CSS was present in the file. It just never applied.Restoring the one brace brings both surfaces back.
Guard added
tests/globals-css.spec.ts, because the stylesheet is the one part of this app with no type checker and this failure mode is completely invisible:}.manual-sheet,.day-flow,.todo-items,.shell— sit at the top level, so a future append can't land inside an earlier block or a media query and go deadBalanced braces alone wouldn't have caught a whole feature accidentally nested in a media query, hence the second test.
Test plan
.manual-sheetcomputes towidth: 768px; padding: 20px(was full-bleed with none), and the page renders with its container, rules, and condensed headings/manualand/daysboth 200 on the fixed buildpnpm exec tsc --noEmitclean; eslint clean on changed filesNo-ticket: true
🤖 Generated with Claude Code
https://claude.ai/code/session_01Mm4zPLAX77USAqyk12jgc1
Generated by Claude Code