The phone's media rows actually show the media - #133
Merged
Conversation
"Has media · 24" answered with rows that said "1 media" and drew nothing. Three reasons, all of them on the phone: - The phone's filtered list, its day panel, and the search results all built their rows without a way to open a photo, and the row only renders media when it has one. So no thumb, no tile, at any size. Media opens in place on the phone exactly as it does at the desk — the lightbox was always full-screen and always mounted. - Asked for media, a row showed only what had a picture in it, so an audio Capture — the row that says "1 media" and offers nothing — drew nothing by construction. In the gallery a row now shows everything it holds, a clip included. - A clip opened in the lightbox fell through to <img> and rendered broken. Audio gets an <audio> element. Verified at the phone seam: the chip's own URL, tiles wider than 120px carrying a blob: picture, a tile for the clip, and the lightbox opening and closing over the day. No-ticket: true
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reported from a phone: "Has media · 24", rows that say 1 media, and nothing drawn. The gallery work in #131 only ever reached the desk. Three separate reasons, all on the phone:
ThreadRowwithoutonOpenMedia, and the row only renders media when it has that handler — so no thumb and no tile, at any size. Media now opens in place on the phone exactly as at the desk; the lightbox was always full-screen and always mounted, so nothing was standing in the way.videobranch into<img>. Audio gets an<audio controls>element.No-ticket: true
Test plan
tests/desk-gallery-phone.spec.ts(pixel-9, at the phone viewport where this was reported) — pressing Has media goes to?media=anyand draws a gallery for each media Thread while the wordy one is filtered out; the photo tile is wider than 120px and carries ablob:image; the clip gets its own tile; tapping opens the lightbox over the day and closes again; a clip opens as<audio>with no<img>presentpnpm typecheckclean;pnpm test— 304 passed, 1 failed (trash-repository.spec.ts, Neon-backed, fails identically on a clean checkout ofmainhere), 10 skippedpnpm lint— 6 errors, all pre-existingStill true after this
A Capture whose original was removed from the device still has nothing to draw, because the retained "thumbnail" is a
text/plainplaceholder rather than a real raster thumbnail. Its tile is an honest glyph with the filename. That is the media-retention gap noted on #131 and wants its own ticket.Generated by Claude Code