Add Minecraft 26.2 support, item input, and optional ChestSort/WG#8
Open
MrSimpleJS wants to merge 5 commits into
Open
Add Minecraft 26.2 support, item input, and optional ChestSort/WG#8MrSimpleJS wants to merge 5 commits into
MrSimpleJS wants to merge 5 commits into
Conversation
…uard hooks Updated OpenShulker for Minecraft 26.2 while keeping api-version: 1.14 for backward compatibility. Added direct item insertion into shulker boxes via right-click interactions. Added optional ChestSort and WorldGuard integration. Fixed protected-container interaction by no longer uncancelling PlayerInteractEvent. Custom shulker display names are now used as the opened inventory title. Details Paper API updated to 26.2.build.31-alpha. Java target remains Java 8 for old server compatibility. Added softdepend: [ChestSort, WorldGuard]. Added config toggles:Hooks.ChestSort Hooks.WorldGuard ChestSort hook marks virtual shulker inventories as unsortable. WorldGuard hook checks Flags.BUILD before opening/inputting shulkers from protected container inventories. Right-click item input supports:item cursor on shulker box shulker box cursor on item Prevents shulker-in-shulker insertion.
Owner
|
Wow, thanks for the PR :3 I'll test this as soon ad the temperatures have cooled down |
- Fixed crash cases when an opened shulker’s source container or world no longer exists. - Removed the temporary NBT marker used for Ender Chest ownership checks. - Added safer cleanup for stale open-shulker state. - Guarded delayed opening so invalid/offline player states do not leave broken markers behind. - Prevented item input into already opened shulker boxes. - Added missing `Player` type checks in inventory listeners. - Fixed the `CloseSound` fallback config key. - Fixed the broken color code in the default config.
Add Folia support while preserving Paper/Spigot compatibility from Minecraft 1.14 through 26.2.
Logs ChestSort and WorldGuard hook status on plugin startup. Adds config migration for missing keys in older config files. Adds Hooks.ChestSortDebug to optionally warn when ChestSort is installed but its API cannot be used. Keeps ChestSort debug warnings disabled by default. Updates default config with the new debug option.
Owner
|
Any clarifications, please? |
Author
|
No further clarifications regarding OpenShulker, thank you. However, I noticed that the PlugManX JAR published on Modrinth may have been built incorrectly. My working jar is about 2.6 MB, whereas the published jar is only around 250 KB and appears to be missing bundled dependencies. Could you please check the published jar? |
Owner
Oh no... I think I know what happened... |
Owner
|
I realized I didn't submit the review... |
Replaced the direct ItemStack#equals check with isSimilar, since ownership is already verified through the Ender Chest inventory.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated OpenShulker for Minecraft 26.2 while keeping api-version: 1.14 for backward compatibility.
Added direct item insertion into shulker boxes via right-click interactions.
Added optional ChestSort and WorldGuard integration.
Fixed protected-container interaction by no longer uncancelling PlayerInteractEvent.
Custom shulker display names are now used as the opened inventory title.
Details
Paper API updated to 26.2.build.31-alpha.
Java target remains Java 8 for old server compatibility.
Added softdepend: [ChestSort, WorldGuard].
Added config toggles:Hooks.ChestSort
Hooks.WorldGuard
ChestSort hook marks virtual shulker inventories as unsortable.
WorldGuard hook checks Flags.BUILD before opening/inputting shulkers from protected container inventories.
Right-click item input supports:item cursor on shulker box shulker box cursor on item
Prevents shulker-in-shulker insertion.
OpenShulker-1.4.0.zip