Conversation
When zooming to a mappable's rectangle, use the same code path we have for `Rectangle` which is smarter and sets a minimum viewing distance instead of simply fitting the camera view to the rectangle. This is a better behaviour when zooming to simple shapes like a single polygon.
na9da
marked this pull request as ready for review
July 17, 2026 01:56
Collaborator
|
@na9da 2 tests are failing
Other than that, zoom looks much better now |
Collaborator
Author
|
Thanks @zoran995. Fixed. The spec was relying on the zoom happening immediately which was no longer happening because of the nested call. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
When zooming to a mappable's rectangle, use the same code path we have for
Rectanglewhich is smarter and sets a minimum viewing distance instead of simply fitting the camera view to the rectangle. This is a better behaviour when zooming to simple shapes like a single polygon.Test me
Before:
mainbranch and zoom to the item in workbenchAfter:
Checklist
doc/.