Skip to content

Migrate Manopt solver callbacks - #36

Open
sChoiKr wants to merge 1 commit into
mainfrom
fix-manopt-callback-routing
Open

Migrate Manopt solver callbacks#36
sChoiKr wants to merge 1 commit into
mainfrom
fix-manopt-callback-routing

Conversation

@sChoiKr

@sChoiKr sChoiKr commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Summary

  • separate Manopt display/debug actions from solver lifecycle callbacks
  • route post-step, diagnostics, progress, and component-trace hooks through callbacks=
  • preserve initial-point and per-step trace semantics with :Init and :Step
  • require Manopt 0.6.2+, where the generic callback API is available

Root cause

TensorKitchen passed raw Julia callback functions through Manopt's legacy debug= path. Newer Manopt releases wrap those functions in deprecated DebugCallback actions, producing warnings when features such as component_trace=true are enabled.

Impact

RGD, fixed-step RGD, RCG, L-BFGS, and LM now keep display actions on debug= while lifecycle callbacks use callbacks=. Component traces retain one entry per completed solver iteration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant