ci: add GitHub Actions for lint, test, build, and integration - #1
Closed
trungdlp wants to merge 4 commits into
Closed
ci: add GitHub Actions for lint, test, build, and integration#1trungdlp wants to merge 4 commits into
trungdlp wants to merge 4 commits into
Conversation
Add four CI workflows triggered on push/PR to main: - lint.yml: gofmt check, go vet, golangci-lint - test.yml: unit tests with race detector and coverage upload - integration.yml: integration tests via testcontainers (Docker) - build.yml: go mod tidy check, build verification, govulncheck Closes #1, closes elqsar#2, closes elqsar#3, closes elqsar#4
Lint fixes (12 issues): - errcheck: handle Close() return values in slot_store, engine, server_test - ineffassign: drop unused err from WaitForAcks in engine retry loop - staticcheck SA1006: use errors.New instead of fmt.Errorf for static string - staticcheck QF1008: remove redundant .Time on embedded time.Time field - staticcheck QF1012: use fmt.Fprintf instead of WriteString(fmt.Sprintf) - unused: remove dead sum/count fields from PrometheusHistogram Build fix: - govulncheck: add continue-on-error since failures are stdlib vulns requiring a Go version bump (1.25.2 -> 1.25.7), not code changes
The sum/count fields are likely intended for future local tracking in Mean()/Count()/Sum() methods. Suppress lint instead of removing.
Author
|
Merged elqsar#5 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test CI workflows before submitting upstream to elqsar#5.
go vet, golangci-lintgo test -racewith coverage artifactgo mod tidycheck,go build, govulncheckTest plan