Merge pull request elqsar#5 from TeneficGames/trduong/add-github-ci

ci: add GitHub Actions for lint, test, build, and integration

Author: elqsar

.github/workflows/build.yml

@@ -0,0 +1,37 @@
+name: Build
+
+on:
+  push:
+    branches: [main]
+  pull_request:
+    branches: [main]
+
+permissions:
+  contents: read
+
+jobs:
+  build:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+
+      - uses: actions/setup-go@v5
+        with:
+          go-version-file: go.mod
+
+      - name: Check go mod tidy
+        run: |
+          go mod tidy
+          if ! git diff --exit-code go.mod go.sum; then
+            echo "::error::go.mod or go.sum is not tidy. Run 'go mod tidy' and commit."
+            exit 1
+          fi
+
+      - name: Build
+        run: go build ./...
+
+      - name: Run govulncheck
+        continue-on-error: true
+        run: |
+          go install golang.org/x/vuln/cmd/govulncheck@latest
+          govulncheck ./...

.github/workflows/integration.yml

@@ -0,0 +1,25 @@
+name: Integration Tests
+
+on:
+  push:
+    branches: [main]
+  pull_request:
+    branches: [main]
+  workflow_dispatch:
+
+permissions:
+  contents: read
+
+jobs:
+  integration-test:
+    runs-on: ubuntu-latest
+    timeout-minutes: 10
+    steps:
+      - uses: actions/checkout@v4
+
+      - uses: actions/setup-go@v5
+        with:
+          go-version-file: go.mod
+
+      - name: Run integration tests
+        run: go test -tags=integration -v -timeout=3m ./tests/integration/

.github/workflows/lint.yml

@@ -0,0 +1,37 @@
+name: Lint
+
+on:
+  push:
+    branches: [main]
+  pull_request:
+    branches: [main]
+
+permissions:
+  contents: read
+
+jobs:
+  lint:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+
+      - uses: actions/setup-go@v5
+        with:
+          go-version-file: go.mod
+
+      - name: Check gofmt
+        run: |
+          unformatted=$(gofmt -l .)
+          if [ -n "$unformatted" ]; then
+            echo "::error::Files not formatted with gofmt:"
+            echo "$unformatted"
+            exit 1
+          fi
+
+      - name: Run go vet
+        run: go vet ./...
+
+      - name: Run golangci-lint
+        uses: golangci/golangci-lint-action@v7
+        with:
+          version: latest

.github/workflows/test.yml

@@ -0,0 +1,29 @@
+name: Test
+
+on:
+  push:
+    branches: [main]
+  pull_request:
+    branches: [main]
+
+permissions:
+  contents: read
+
+jobs:
+  unit-test:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+
+      - uses: actions/setup-go@v5
+        with:
+          go-version-file: go.mod
+
+      - name: Run unit tests
+        run: go test -race -coverprofile=coverage.out ./...
+
+      - name: Upload coverage
+        uses: actions/upload-artifact@v4
+        with:
+          name: coverage
+          path: coverage.out

internal/checkpoint/slot_store.go

@@ -32,7 +32,7 @@ func (s *SlotStore) Load(ctx context.Context) (model.WALPosition, error) {
 	if err != nil {
 		return model.WALPosition{}, fmt.Errorf("slot store connect: %w", err)
 	}
-	defer conn.Close(ctx)
+	defer conn.Close(ctx) //nolint:errcheck
 
 	result := conn.ExecParams(
 		ctx,

internal/engine/engine.go

@@ -95,7 +95,7 @@ func (e *Engine) Run(ctx context.Context, start model.WALPosition) error {
 	if err := e.publisher.Connect(); err != nil {
 		return fmt.Errorf("publisher connect: %w", err)
 	}
-	defer e.publisher.Close()
+	defer e.publisher.Close() //nolint:errcheck
 
 	return e.runBatched(ctx, parsedStream)
 }
@@ -398,7 +398,7 @@ func (e *Engine) publishWithRetry(ctx context.Context, batchPub publisher.BatchP
 		}
 
 		// Wait for acks
-		result, err := batchPub.WaitForAcks(ctx, pending, pubItems, timeout)
+		result, _ := batchPub.WaitForAcks(ctx, pending, pubItems, timeout)
 
 		// Context cancelled - return what we have
 		if ctx.Err() != nil {

internal/health/server_test.go

@@ -100,7 +100,7 @@ func TestStart_ReturnsErrorWhenAddrInUse(t *testing.T) {
 	if err != nil {
 		t.Fatalf("listen: %v", err)
 	}
-	defer ln.Close()
+	defer ln.Close() //nolint:errcheck
 
 	ctx, cancel := context.WithCancel(context.Background())
 	defer cancel()
@@ -131,7 +131,7 @@ func TestStart_ServesHealthEndpoint(t *testing.T) {
 	for time.Now().Before(deadline) {
 		resp, err := client.Get("http://" + addr + "/health")
 		if err == nil {
-			defer resp.Body.Close()
+			defer resp.Body.Close() //nolint:errcheck
 			if resp.StatusCode != http.StatusOK {
 				t.Fatalf("expected 200, got %d", resp.StatusCode)
 			}

internal/metrics/prometheus.go

@@ -62,8 +62,8 @@ func (g *PrometheusGauge) Get() int64 {
 // PrometheusHistogram wraps prometheus.Histogram with the same interface as Histogram.
 type PrometheusHistogram struct {
 	histogram prometheus.Histogram
-	sum       float64
-	count     uint64
+	sum       float64 //nolint:unused
+	count     uint64  //nolint:unused
 }
 
 // NewPrometheusHistogram creates a new Prometheus histogram with the given buckets.

internal/parser/wal2json_test.go

@@ -71,10 +71,10 @@ func TestPgTime_UnmarshalJSON(t *testing.T) {
 			if err != nil {
 				t.Fatalf("unexpected error: %v", err)
 			}
-			if tt.isZero && !v.Time.IsZero() {
+			if tt.isZero && !v.IsZero() {
 				t.Fatalf("expected zero time, got %v", v.Time)
 			}
-			if !tt.isZero && v.Time.IsZero() {
+			if !tt.isZero && v.IsZero() {
 				t.Fatal("expected non-zero time, got zero")
 			}
 		})
@@ -89,7 +89,7 @@ func TestPgTime_InStruct(t *testing.T) {
 	if err := json.Unmarshal([]byte(raw), &msg); err != nil {
 		t.Fatalf("unmarshal with null timestamp: %v", err)
 	}
-	if !msg.Timestamp.Time.IsZero() {
+	if !msg.Timestamp.IsZero() {
 		t.Fatalf("expected zero time for null timestamp, got %v", msg.Timestamp.Time)
 	}
 
@@ -98,11 +98,11 @@ func TestPgTime_InStruct(t *testing.T) {
 	if err := json.Unmarshal([]byte(raw), &msg); err != nil {
 		t.Fatalf("unmarshal with real timestamp: %v", err)
 	}
-	if msg.Timestamp.Time.IsZero() {
+	if msg.Timestamp.IsZero() {
 		t.Fatal("expected non-zero time, got zero")
 	}
 	expected := time.Date(2024, 1, 15, 15, 30, 0, 123456000, time.UTC)
-	if !msg.Timestamp.Time.Equal(expected) {
+	if !msg.Timestamp.Equal(expected) {
 		t.Fatalf("expected %v, got %v", expected, msg.Timestamp.Time)
 	}
 }

internal/publisher/publisher.go

@@ -2,6 +2,7 @@ package publisher
 
 import (
 	"context"
+	"errors"
 	"fmt"
 	"strings"
 	"sync"
@@ -185,7 +186,7 @@ func (p *NoopPublisher) PublishWithRetries(ctx context.Context, subject string,
 
 func (p *NoopPublisher) Close() error { return nil }
 
-func (p *NoopPublisher) Ready(context.Context) error { return fmt.Errorf(noopPublisherReadyError) }
+func (p *NoopPublisher) Ready(context.Context) error { return errors.New(noopPublisherReadyError) }
 
 // SubjectForEvent builds subject cdc.{database}.{schema}.{table}.
 func SubjectForEvent(database string, evt *model.CDCEvent) (string, error) {