Skip to content

修复 pesapi-v8：pesapi_release_value_ref 未 Reset value_persistent 导致 marshal 的 JS 函数泄露 #2342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chexiongsheng merged 1 commit into from
Jun 4, 2026
+5 −0
Merged

修复 pesapi-v8：pesapi_release_value_ref 未 Reset value_persistent 导致 marshal 的 JS 函数泄露 #2342

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions unity/native/papi-v8/source/PesapiV8Impl.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -692,6 +692,11 @@ void pesapi_release_value_ref(pesapi_value_ref value_ref)
{
if (!value_ref->env_life_cycle_tracker.expired())
{
// v8::Persistent uses NonCopyablePersistentTraits (kResetInDestructor == false),
// so ~pesapi_value_ref__() does NOT release the strong V8 global root. Without an
// explicit Reset(), a JS function marshaled into a C# delegate (this path never calls
// pesapi_set_ref_weak) and everything its closure captures leak for the isolate's lifetime.
value_ref->value_persistent.Reset();
value_ref->~pesapi_value_ref__();
}
::operator delete(static_cast<void*>(value_ref));
Expand Down
Loading