Repository navigation
fix(local): preserve manual gates without PyYAML - #63
Open
MertensMing wants to merge 1 commit into
Open
MertensMing wants to merge 1 commit into
MertensMing wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Fixes #49.
The Classic CodeBuddy hook skipped manual gates without PyYAML. It now reads plain
multi.auto_modesettings with the standard library.The log records
config_unreadablefor read or parse errors. Thanks to pcbeingused333 for the follow-up discussion in #49.Scope
Compatibility
This change affects the Classic CodeBuddy hook. The fallback supports plain block mappings and boolean values. Complex syntax without PyYAML keeps manual gates with main. PyYAML remains the parser for full YAML syntax.
Evidence
Validation
Commands ran from
local/.python3 scripts/build-classic-hosts.py --writeand--check.bash scripts/validate.sh.bash scripts/smoke-install.sh.bash scripts/smoke-npm.sh.bash scripts/smoke-curl-install.sh.bash scripts/e2e.sh(30 tests, one browser suite skipped).bash scripts/test-observability.sh(132 tests).bash scripts/scan-secrets.shrequires Linux x86_64. This machine runs macOS.Safety
Merge Danger
Door: two-way
Blast Radius: CodeBuddy
Unsupported YAML syntax without PyYAML requires manual review at gate events.